Skip to content

fix: skip RayVirtualCluster.shutdown when Ray already torn down #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuki-97 merged 1 commit into from
Jul 14, 2026
Merged

fix: skip RayVirtualCluster.shutdown when Ray already torn down #3148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nemo_rl/distributed/virtual_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,11 @@ def shutdown(self) -> bool:

This method is idempotent and can be safely called multiple times.
"""
# Skip if Ray is already gone (typically from __del__ during _Py_Finalize
# after Ray's atexit teardown). Any Ray API call would trigger a fatal
# core_worker_process.cc:88 CHECK. Placement groups die with Ray.
if not ray.is_initialized():
return True
if self._node_placement_groups is not None:
# Remove all placement groups
for pg in self._node_placement_groups:
Expand Down
Loading