docs(mopd): fix dataset override key data.val -> data.validation - #2991
Merged
Conversation
github-actions
Bot
added
the
Documentation
yuki-97
approved these changes
Jul 1, 2026
yuki-97
left a comment
yuki-97
left a comment
Contributor
There was a problem hiding this comment.
thanks @qiaochuz-nv , fix LGTM, could you help to solve the DCO fail?
The MOPD quickstart CLI example overrode the validation dataset path with data.val.data_path, but the shipped recipe (examples/configs/recipes/llm/mopd-qwen3-1.7b-3n8g-megatron-pack.yaml) keys the validation block under data.validation. Verbatim copy-paste of the doc command hits an OmegaConf 'key not found' error. Align the doc with the recipe. Signed-off-by: Qiaochu Zhu <qiaochuz@nvidia.com>
qiaochuz-nv
force-pushed
the
qiaochuz/fix-mopd-doc-data-validation
branch
from
July 1, 2026 05:45
61c70be to
d520e8b
Compare
Contributor
|
/ok to test d520e8b |
yuki-97
enabled auto-merge (squash)
July 1, 2026 05:54
yuki-97
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The MOPD quickstart CLI example in
docs/about/algorithms/mopd.mdoverrides the validation dataset path withdata.val.data_path, but the shipped recipe (examples/configs/recipes/llm/mopd-qwen3-1.7b-3n8g-megatron-pack.yaml) keys the validation block underdata.validation:Copy-pasting the documented command verbatim hits an OmegaConf "key not found" error.
Fix
One-line doc change to align the example with the recipe:
(
data.train.data_pathon the line above is already correct.)Verification
Found while authoring the RL POR e2e test for MOPD (#2780). Confirmed the recipe uses
data.validationand the documenteddata.valwould fail config resolution.