Skip to content

fix: Fixed max seqlen not respected correctly #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SahilJain314 merged 2 commits into from
Apr 30, 2025
Merged

fix: Fixed max seqlen not respected correctly #299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b766c17
Fixed max seqlen not respected correctly
SahilJain314 Apr 30, 2025
f8b739c
Added unit test for max seqlen multiturn
SahilJain314 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_rl/experience/rollouts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def run_multi_turn_rollout(
>= max_seq_len
):
# truncate
tokenized_obs = tokenized_obs[: max_seq_len - active_input_lengths[i]]
tokenized_obs = tokenized_obs[: max_seq_len - (len(generated_ids[i]) + active_input_lengths[i])]
Comment thread
SahilJain314 marked this conversation as resolved.
Outdated
truncation_mask[i] = True
# Record truncation
sample_truncated[active_indices[i]] = True
Expand Down