Skip to content

fix(grpo_sync): skip refit for colocated MegatronGeneration #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuki-97 merged 1 commit into from
Jun 30, 2026
Merged

fix(grpo_sync): skip refit for colocated MegatronGeneration #2967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion nemo_rl/algorithms/grpo_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
from nemo_rl.environments.interfaces import EnvironmentInterface
from nemo_rl.experience.sync_rollout_actor import SyncRolloutActor
from nemo_rl.models.generation.interfaces import GenerationInterface
from nemo_rl.models.generation.megatron import MegatronGeneration
from nemo_rl.models.policy.interfaces import ColocatablePolicyInterface
from nemo_rl.utils.checkpoint import CheckpointManager
from nemo_rl.utils.logger import Logger, print_message_log_samples
Expand Down Expand Up @@ -404,7 +405,10 @@ def grpo_train_sync(

kv_scales_cache = None # Cache reused for computed kv scales

NEED_REFIT = True
NEED_REFIT = not (
isinstance(policy_generation, MegatronGeneration)
and master_config.policy["generation"]["colocated"]["enabled"]
)
# If policy_generation is None, use the policy as the generation interface (megatron framework backend)
if policy_generation is None:
policy_generation = policy # type: ignore
Expand Down
Loading