Repository navigation
feat: R3 gym notq router replay #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6bfbf0b
feat: support R3 router replay for async Gym rollouts
zyzhou5 87b3c9e
test: cover async vLLM routed expert chat attachment
zyzhou5 1e39dd6
fix: preserve R3 routes in async vLLM chat JSON
zyzhou5 c25a0bf
refactor: move async chat R3 hook into mixin
zyzhou5 aefdfaf
test: cover async chat R3 route attachment guards
zyzhou5 8aa2f2f
test: add R3 nightly coverage configs
zyzhou5 0a2718d
test: simplify R3 async nightly names
zyzhou5 ca5ea9b
test: shorten R3 Gym nightly
zyzhou5 25c2f00
test: add R3 recipes to nightly suite
zyzhou5 6b8df98
test: use updated nightly GPU-hour cap
zyzhou5 43d34b5
test: minimize R3 nightly recipes
zyzhou5 f2059d2
Merge branch 'main' into r3-gym-notq-router-replay
yuki-97 58b6af1
increase nightly 3000 -> 3270 (current 3232)
yuki-97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| # Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import pytest | ||
|
|
||
| from nemo_rl.environments.nemo_gym import NemoGym | ||
|
|
||
|
|
||
| class _Tokenizer: | ||
| def batch_decode(self, batch): | ||
| return [" ".join(map(str, token_ids)) for token_ids in batch] | ||
|
|
||
|
|
||
| def _routes(num_tokens: int) -> list[list[list[int]]]: | ||
| return [[[token_idx, token_idx + 100]] for token_idx in range(num_tokens)] | ||
|
|
||
|
|
||
| def test_nemo_gym_postprocess_slices_routed_experts(): | ||
| nemo_gym_result = { | ||
| "response": { | ||
| "output": [ | ||
| { | ||
| "prompt_token_ids": [1, 2], | ||
| "generation_token_ids": [3], | ||
| "generation_log_probs": [-0.1], | ||
| "routed_experts": _routes(3), | ||
| }, | ||
| { | ||
| "prompt_token_ids": [1, 2, 3, 4, 5], | ||
| "generation_token_ids": [6, 7], | ||
| "generation_log_probs": [-0.2, -0.3], | ||
| "routed_experts": _routes(7), | ||
| }, | ||
| ] | ||
| }, | ||
| "responses_create_params": {"input": []}, | ||
| } | ||
|
|
||
| class _MockSelf: | ||
| cfg = {"require_routed_experts": True} | ||
|
|
||
| result = ( | ||
| NemoGym.__ray_metadata__.modified_class._postprocess_nemo_gym_to_nemo_rl_result( | ||
| _MockSelf(), nemo_gym_result, _Tokenizer() | ||
| ) | ||
| ) | ||
|
|
||
| message_log = result["message_log"] | ||
| assert message_log[0]["token_ids"].tolist() == [1, 2] | ||
| assert message_log[0]["routed_experts"].tolist() == _routes(2) | ||
| assert message_log[1]["token_ids"].tolist() == [3] | ||
| assert message_log[1]["routed_experts"].tolist() == _routes(3)[2:3] | ||
| assert message_log[2]["token_ids"].tolist() == [4, 5] | ||
| assert message_log[2]["routed_experts"].tolist() == _routes(7)[3:5] | ||
| assert message_log[3]["token_ids"].tolist() == [6, 7] | ||
| assert message_log[3]["routed_experts"].tolist() == _routes(7)[5:7] | ||
|
|
||
|
|
||
| def test_nemo_gym_postprocess_requires_routed_experts_when_configured(): | ||
| nemo_gym_result = { | ||
| "response": { | ||
| "output": [ | ||
| { | ||
| "prompt_token_ids": [1, 2], | ||
| "generation_token_ids": [3], | ||
| "generation_log_probs": [-0.1], | ||
| }, | ||
| ] | ||
| }, | ||
| "responses_create_params": {"input": []}, | ||
| } | ||
|
|
||
| class _MockSelf: | ||
| cfg = {"require_routed_experts": True} | ||
|
|
||
| with pytest.raises(ValueError, match="requires NeMo Gym output items"): | ||
| NemoGym.__ray_metadata__.modified_class._postprocess_nemo_gym_to_nemo_rl_result( | ||
| _MockSelf(), nemo_gym_result, _Tokenizer() | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.