fix: lower mooncake memory in functional test - #2584
Merged
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test 4711c08 |
Signed-off-by: Yuki Huang <yukih@nvidia.com>
yuki-97
force-pushed
the
yukih/lower-mooncake-memory
branch
from
May 27, 2026 09:20
4711c08 to
3fbc3f8
Compare
Contributor
Author
|
/ok to test 3fbc3f8 |
This reverts commit 3fbc3f8. Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test da9f03b |
ZhiyuLi-Nvidia
approved these changes
May 27, 2026
ZhiyuLi-Nvidia
left a comment
Contributor
There was a problem hiding this comment.
Thank you @yuki-97 ! LGTM!
vigneshwaran
pushed a commit
to vigneshwaran/RL
that referenced
this pull request
May 28, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix
./tests/functional/grpo_dp_mooncake.shfail in CI (action link) when using A100 by lower mooncake memory suggested by @ZhiyuLi-NvidiaTest Result
confirmed in action link using 3fbc3f8.