-
Notifications
You must be signed in to change notification settings - Fork 546
feat: add delta-compressed collective refit #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
terrykong
merged 18 commits into
NVIDIA-NeMo:main
from
HollowMan6:delta_weight_transfer
Jul 19, 2026
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cc0076a
feat: add S3-based delta-compressed collective refit
HollowMan6 ab626af
Add zeromq implementation
HollowMan6 b7160b5
add more test cases
HollowMan6 bfd4259
minimizing the code surface for easier maintainance
HollowMan6 983f82f
Add calculator
HollowMan6 4ab3f33
Clean up
HollowMan6 9d386c3
only keep xor and overwrite
HollowMan6 75b1dc9
Use mcore local baseline
HollowMan6 1d37648
Fix test cases
HollowMan6 378c329
Remove vllm internal overwrite
HollowMan6 6935887
Clean up
HollowMan6 caf156f
Remove mcore local baseline and clean up
HollowMan6 f7c1eec
Clean up
HollowMan6 0ce0497
Add nightly tests
HollowMan6 011a259
Increase nightly compute
HollowMan6 5a257c4
Clean up test command
HollowMan6 caeee90
Address review issues
HollowMan6 cf6f490
More detailed diagram in docs
HollowMan6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...les/configs/recipes/llm/grpo-qwen3-30ba3b-4n8g-megatron-zmq-deltaweight-noncolocated.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| defaults: ./performance/grpo-qwen3-30ba3b-4n8g.yaml | ||
|
|
||
| grpo: | ||
| num_prompts_per_step: 16 | ||
| num_generations_per_prompt: 8 | ||
| max_num_steps: 50 | ||
| val_period: 1000 | ||
|
|
||
| checkpointing: | ||
| checkpoint_dir: results/grpo-qwen3-30ba3b-4n8g-megatron-zmq-deltaweight-noncolocated | ||
|
|
||
| policy: | ||
| train_global_batch_size: 128 | ||
| generation_batch_size: 16 | ||
| max_total_sequence_length: 2048 | ||
| sequence_packing: | ||
| train_mb_tokens: 2048 | ||
| logprob_mb_tokens: 4096 | ||
| megatron_cfg: | ||
| activation_checkpointing: true | ||
| env_vars: | ||
| PYTORCH_CUDA_ALLOC_CONF: expandable_segments:True | ||
| generation: | ||
| refit_transport: vllm_zmq_sparse | ||
| refit_cfg: | ||
| delta_compression: | ||
| encoding: xor | ||
| verify_samples_per_payload: 0 | ||
| baseline: | ||
| in_memory: false | ||
| colocated: | ||
| enabled: false | ||
| resources: | ||
| gpus_per_node: 8 | ||
| num_nodes: 2 | ||
|
|
||
| logger: | ||
| log_dir: logs/grpo-qwen3-30ba3b-4n8g-megatron-zmq-deltaweight-noncolocated | ||
| wandb: | ||
| project: nemo-rl-refit | ||
| name: grpo-qwen3-30ba3b-4n8g-megatron-zmq-deltaweight-noncolocated | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.