chore: bump transformer-engine to 2.14.1 - #2434
Merged
terrykong merged 1 commit intoMay 8, 2026
Merged
Conversation
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
zpqiu
marked this pull request as ready for review
May 7, 2026 09:19
Contributor
Author
|
/ok to test 0d05f0a |
Contributor
Author
|
Hi @terrykong, Sharon has run the nightly tests twice. Here is the CI link: https://gitlab-master.nvidia.com/dl/JoC/nemo-ci/-/pipelines/50603458. Some tests failed, but they don’t seem to be related to this bump PR. The analysis report generated by CC is below. Do these results look acceptable to you? |
Collaborator
|
Yea, i think those failures seem unrelated, this PR lgtm |
terrykong
enabled auto-merge (squash)
May 8, 2026 04:32
terrykong
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Related Issues
#2320
Additional Info
The current TE version pinned by RL has a checkpoint resume problem with FusedAdam.
That snapshot includes the FusedAdam DTensor/local-state change, but misses the later DCP compatibility fix. As a result, FusedAdam optimizer states for degenerate sharded params such as
shared_expert_gate.weight [1, 2048]were saved with rank-local metadata like(0, 2048)on most ranks and(1, 2048)on a few ranks. Model weights metadata were fine; only optimizer state metadata was corrupted.The fix is to bump Transformer Engine to a version containing
a4a073bbb7c625727b006adacc2a19f4a80cdb61, e.g. TEv2.14commitf031cf87bd054c7558b887df7bed93975456667f.Related PR: NVIDIA/TransformerEngine#2795