Skip to content

deps: bump deep_ep pin to V2 merge commit b306af0 - #2411

Closed
dmvevents wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
dmvevents:bump-deep-ep-v2
Closed

deps: bump deep_ep pin to V2 merge commit b306af0#2411
dmvevents wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
dmvevents:bump-deep-ep-v2

Conversation

@dmvevents

Copy link
Copy Markdown
Contributor

Summary

Bumps deep_ep git pin in pyproject.toml from bfded348 (2025-10-29, pre-V2) to b306af0 (2026-04-29), the merge commit of deepseek-ai/DeepEP#605 "Introducing EPv2: faster EP, and Engram/PP/CP supports".

Why

The current pin predates the DeepEP V2 API reshape (Buffer -> ElasticBuffer, PP/CP/Engram support). Without this bump, consumers who follow the Megatron-side V2 adoption (NVIDIA/Megatron-LM#4632, "Shape Y") cannot import deep_ep.ElasticBuffer because the NeMo-RL virtualenv still installs the pre-V2 tree.

This PR is intentionally scoped to the pin only - it does not change any NeMo-RL code path. End-to-end V2 enablement requires pairing this bump with Megatron-LM#4632.

Scope

Single-file change to pyproject.toml:

  • Three deep_ep @ git+.../DeepEP.git@bfded348... pins become ...@b306af06afd412c88e51e71802951606e40b7358.

Validation / reproduction

End-to-end reproduction (Dockerfile, Kubernetes manifests, 2-node p5en.48xlarge dispatch+combine smoke bench, vLLM MoE end-to-end chat completion) is public at:

https://github.com/antonai-work/nemo-rl-deepep-v2-efa

Verified inside the reproduction tree:

  • deep_ep installs at commit b306af0 with ElasticBuffer import succeeding.
  • DeepEP/tests/elastic/test_ep.py runs on 2x H200 EFA at p50 ~740us dispatch+combine.

Related PRs

Risk / compatibility

  • The pre-V2 deep_ep.Buffer symbol is gone in V2. If a downstream NeMo-RL code path still imports it, that path breaks with or without Megatron#4632. Searches of NVIDIA-NeMo/RL show DeepEP is consumed through Megatron-Core, not directly, so NeMo-RL itself has no direct deep_ep.Buffer call sites.
  • vLLM's V2 integration (vllm-project/vllm#41183) is still open; NeMo-RL installs vLLM independently, so this pin does not force the vLLM venv.

@copy-pr-bot

copy-pr-bot Bot commented May 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Bumps the deep_ep git pin in pyproject.toml from bfded348
(2025-10-29, pre-V2) to b306af0 (2026-04-29), which is the
merge commit of DeepEP PR NVIDIA-NeMo#605 "Introducing EPv2".

Why
---
The current pin predates the DeepEP V2 API (ElasticBuffer,
PP/CP/Engram support). Consumers of NeMo-RL's Megatron backend
that follow NVIDIA/Megatron-LM#4632 ("Shape Y" Megatron V2
adoption) cannot resolve deep_ep.ElasticBuffer with the
current pin; the virtualenv still installs the pre-V2 tree.

This change bumps only the pin. It does not by itself change
any NeMo-RL code path. Paired with Megatron-LM#4632, it
enables the end-to-end V2 path that is already running on
AWS p5en.48xlarge 2x H200 in the reproduction repo below.

Upstream references
-------------------
* deepseek-ai/DeepEP#605 (V2 merge 2026-04-29)
* NVIDIA/Megatron-LM#4632 (Megatron-side V2 adoption)

Reproduction
------------
End-to-end reproduction (Dockerfile + K8s manifests + smoke
bench) is public at:
  https://github.com/antonai-work/nemo-rl-deepep-v2-efa

Related NeMo-RL PR (separate concern, same fleet):
  NVIDIA-NeMo#2410 (Dockerfile LD_LIBRARY_PATH for EFA
  OFI discovery)

Signed-off-by: Anton Alexander <antonai@users.noreply.github.com>
@dmvevents

Copy link
Copy Markdown
Contributor Author

Closing as superseded. This PR bumped the deep_ep pin to the EPv2 public-release commit
(b306af0, 2026-04-29) as a single pin across all extras. Since then main has reorganized the
deep_ep dependency into a platform-split pin (separate x86_64 and aarch64 commits, last
updated 2026-06-20 in the SgLang-rollout refactor #2267).

Rebasing this PR as-is would regress that — it would drop the aarch64 handling and move the pin
backward relative to the current structure — so it's not the right thing to force-merge. The EPv2
intent here is better served by a fresh change against main's platform-split layout if/when an EPv2
bump is desired on both arches. Closing to keep the queue clean; happy to re-open a properly-rebased
version if the maintainers want EPv2 evaluated against the current pins.

@dmvevents dmvevents closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants