-
Notifications
You must be signed in to change notification settings - Fork 555
perf: selective activation checkpointing feature support #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6621d76
Add selective activation recompute support
seonjinn 2c20d69
Update nemo_rl/models/policy/__init__.py
seonjinn 391eb9b
Update nemo_rl/models/megatron/setup.py
seonjinn 38f92e5
Update examples/configs/grpo_math_1B.yaml
seonjinn e5acdd8
Update nemo_rl/models/megatron/setup.py
seonjinn 72d1d15
Merge branch 'main' into sj/selective-recompute
seonjinn 79486ec
Merge branch 'main' into sj/selective-recompute
seonjinn 8102a0d
Merge remote-tracking branch 'origin/main' into sj/selective-recompute
seonjinn 7e54943
Merge remote-tracking branch 'origin/main' into sj/selective-recompute
seonjinn 043ae0c
fix: pin NeMo Gym docs URL to v0.2.1 (latest 404)
seonjinn a3abda4
fix: guard missing recompute_granularity, dedupe lines, sync referenc…
seonjinn d53d346
Merge remote-tracking branch 'origin/main' into sj/selective-recompute
seonjinn 810260c
test: add unit tests for recompute_granularity dispatch
seonjinn c40a482
Merge main into sj/selective-recompute
seonjinn 05ca762
Merge branch 'main' into sj/selective-recompute
seonjinn 638d22a
Merge branch 'main' into sj/selective-recompute
seonjinn 9075f7d
Merge branch 'main' into sj/selective-recompute
seonjinn c4dc71e
Retry CI on L1 grpo_megatron_lora_async reward flake
seonjinn dd16310
Add selective recompute keys to remaining megatron exemplar configs
seonjinn b88ffab
Sync reference_configs with new recompute keys
seonjinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.