-
Notifications
You must be signed in to change notification settings - Fork 541
perf: support fine-grained activation offloading #2279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
feee53e
Add fine-grained activation offloading for Megatron policy
seonjinn 0b530c4
Update nemo_rl/models/policy/__init__.py
seonjinn d5df80a
Update nemo_rl/models/megatron/setup.py
seonjinn f742bf8
Merge remote-tracking branch 'origin/main' into sj/fine-grained-activ…
seonjinn e237987
fix: remove stray paren in setup.py raising ValueError
seonjinn 4f4681c
Merge remote-tracking branch 'origin/main' into sj/fine-grained-activ…
seonjinn 06b4d4a
fix: pin NeMo Gym docs URL to v0.2.1 (latest 404)
seonjinn 2b33ad3
Merge branch 'main' into sj/fine-grained-activation-offload
seonjinn 5225217
test: add unit tests for fine_grained_activation_offloading branch
seonjinn 211e31a
Update nemo_rl/models/megatron/setup.py
seonjinn 502d2dd
Update nemo_rl/models/megatron/setup.py
seonjinn da947f8
Update tests/unit/models/megatron/test_megatron_setup.py
seonjinn fcbd22b
Merge main into sj/fine-grained-activation-offload
seonjinn 254c7d0
Fix syntax error from main merge in offload test
seonjinn 625b25f
Merge branch 'main' into sj/fine-grained-activation-offload
seonjinn ed86517
Address review comments on fine_grained_activation_offloading
seonjinn d89ac84
Address remaining terrykong review comments
seonjinn aaece7b
Allow offload_modules to be None in MegatronConfig TypedDict
seonjinn bcccabf
Merge branch 'main' into sj/fine-grained-activation-offload
seonjinn 08d121d
Merge branch 'main' into sj/fine-grained-activation-offload
seonjinn 0bed72f
Merge branch 'main' into sj/fine-grained-activation-offload
seonjinn 7051195
fix(megatron): honor activation offload overrides
seonjinn 602e7b0
docs: clarify Megatron activation CPU offload
seonjinn 5ddbde8
docs: correct activation offload graph requirement
seonjinn 2f39df6
test(megatron): model activation offload happy path
seonjinn bf3407f
test(megatron): preserve activation offload warmup
seonjinn 3a3bebd
fix(megatron): preserve activation offload warmup
seonjinn 9c79efe
test(megatron): cover offload manager lifecycle
seonjinn aeeb3d6
fix(megatron): suspend activation offload manager
seonjinn 0139846
test(megatron): assert offload warmup state
seonjinn ea09321
Merge remote-tracking branch 'origin/main' into codex/pr2279-main-syn…
seonjinn b9ed160
fix(megatron): address activation offload review feedback
seonjinn fef2afb
Merge remote-tracking branch 'origin/main' into codex/pr2279-main-syn…
seonjinn 6a4f1fc
docs(megatron): future-proof offload module references
seonjinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.