test: add nanov3 prefill decode test#2141
Merged
yuki-97 merged 2 commits intohemil/automodel-transformers-v5from Mar 24, 2026
Merged
test: add nanov3 prefill decode test#2141yuki-97 merged 2 commits intohemil/automodel-transformers-v5from
yuki-97 merged 2 commits intohemil/automodel-transformers-v5from
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
61485e3 to
30f2253
Compare
Contributor
Author
|
/ok to test 30f2253 |
Contributor
Author
|
/ok to test d255ec9 |
terrykong
approved these changes
Mar 23, 2026
Collaborator
|
approved, but let's see where the v5 PR is. if it's almost done by the time this CI finishes, let's just do this in a following up PR to not slow down that PR. check with @yuki-97 on her preference on merging this one |
Contributor
|
thanks @ZhiyuLi-Nvidia @terrykong ! |
1179183
into
hemil/automodel-transformers-v5
47 of 49 checks passed
yuki-97
pushed a commit
that referenced
this pull request
Mar 24, 2026
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
terrykong
pushed a commit
that referenced
this pull request
Mar 24, 2026
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Background add nanov3 prefill decode test.
Vllm prefill and decode should generate consistent logprob. It was an issue before
vllm<0.17.0and fixed invllm==0.17.0. Add the test to guard vllm prefill and decode logprob consistency.Issues
It was an issue as per #2100
Fixed after vllm bump up.
Background:
I’d expect bump up vllm version to vLLM 0.17.0 would resolve the issue:
Some findings are as follows:
old vllm version is self-conflicting while megatron is good
prefillvllm prefill is like pass all prompt generated tokens to vllm and let it calculate logprobs, it is similar as a single forward pass in training.
after bumping up vllm to 0.17.0 using the container /lustre/fsw/portfolios/coreai/users/terryk/enroot-images/gitlab-master.nvidia.com/terryk/images/nemo-rl:hemil-automodel-transformers-v5-9db945aa4.squashfs
I think the root cause should be relevant to the prefill/decode kernel with mamba, kv cache and they were fixed with vllm bump up.
Usage
See tests.
Before your PR is "Ready for review"
Pre checks:
Additional Information