Skip to content

ci: Fix sso user check - #2126

Merged
chtruong814 merged 1 commit into
mainfrom
chtruong/fix-sso
Mar 19, 2026
Merged

ci: Fix sso user check#2126
chtruong814 merged 1 commit into
mainfrom
chtruong/fix-sso

Conversation

@chtruong814

@chtruong814 chtruong814 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

ci: Fix sso user check

The file name we used to check if a user is internal or not changed. Updating the workflow to pass in the file name via a Github variable so we can change it later if needed.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Updated internal CI/CD workflow configuration and dependencies to the latest versions.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
chtruong814 requested a review from a team as a code owner March 19, 2026 03:46
@copy-pr-bot

copy-pr-bot Bot commented Mar 19, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI Relating to CI label Mar 19, 2026
@chtruong814 chtruong814 added the CI:docs Run doctest label Mar 19, 2026
@chtruong814

Copy link
Copy Markdown
Contributor Author

/ok to test

@chtruong814

Copy link
Copy Markdown
Contributor Author

Fast merging this to ensure CI is working as expected.

@chtruong814
chtruong814 merged commit ee0c75b into main Mar 19, 2026
23 checks passed
@chtruong814
chtruong814 deleted the chtruong/fix-sso branch March 19, 2026 03:49
@coderabbitai

coderabbitai Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0af7fb7-d719-4cd6-9022-3dde42662830

📥 Commits

Reviewing files that changed from the base of the PR and between c4a47a0 and 83da8ee.

📒 Files selected for processing (1)
  • .github/workflows/cicd-main.yml

📝 Walkthrough

Walkthrough

Updated the org-member-pre-flight reusable workflow reference from version 0.78.0 to 0.80.1 and added a new sso_users_filename input parameter with a value sourced from repository variables.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/cicd-main.yml
Updated org-member-pre-flight workflow dependency from v0.78.0 to v0.80.1 and added sso_users_filename input parameter to the job configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: Fix sso user check' directly and concisely describes the main change: fixing the CI workflow's SSO user validation check by updating the workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor CI workflow configuration changes updating reusable workflow reference and adding input parameter.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chtruong/fix-sso
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant