Skip to content

feat: Add hydra style overrides to SFT #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 4 commits into from
Apr 29, 2025
Merged

feat: Add hydra style overrides to SFT #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02d78ea
Add hydra style overrides to SFT
hemildesai Apr 17, 2025
124932b
Merge branch 'main' of github.com:NVIDIA/reinforcer into hemil/hydra-…
ashors1 Apr 28, 2025
7685a7f
renaming fix
ashors1 Apr 28, 2025
7c6dfe9
fix failing sft test
ashors1 Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions examples/run_sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from nemo_rl.data.interfaces import TaskDataSpec, DatumSpec
from nemo_rl.data.llm_message_utils import get_formatted_message_log
from nemo_rl.distributed.virtual_cluster import init_ray
from nemo_rl.utils.config import load_config
from nemo_rl.utils.config import load_config, parse_hydra_overrides
from nemo_rl.utils.logger import get_next_experiment_dir


Expand All @@ -40,10 +40,7 @@ def parse_args():
)

# Parse known args for the script
args, remaining = parser.parse_known_args()

# Convert remaining args to OmegaConf format
overrides = OmegaConf.from_dotlist(remaining)
args, overrides = parser.parse_known_args()

return args, overrides

Expand Down Expand Up @@ -154,7 +151,7 @@ def main():

if overrides:
print(f"Overrides: {overrides}")
config = OmegaConf.merge(config, overrides)
config = parse_hydra_overrides(config, overrides)

config: MasterConfig = OmegaConf.to_container(config, resolve=True)
print("Applied CLI overrides")
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/sft.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ python -u $PROJECT_ROOT/examples/run_sft.py \
logger.log_dir=$LOG_DIR \
logger.wandb_enabled=false \
checkpointing.enabled=true \
checkpointing.save_every_n_steps=10 \
checkpointing.save_period=10 \
checkpointing.checkpoint_dir=/tmp/sft_checkpoints \
$@ \
2>&1 | tee $RUN_LOG
Expand Down