-
Notifications
You must be signed in to change notification settings - Fork 460
feat: Add chunked linear ce loss function from hidden states #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuki-97
merged 28 commits into
NVIDIA-NeMo:main
from
pengdurice:peng-add-linear-ce-fusion-v1
Mar 19, 2026
Merged
Changes from 5 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b593561
first commit, will clean up and add local tests
pengdurice 52b85d4
code clean up and unit tests added
pengdurice 9ad25fe
more code clean up
pengdurice 322bea8
remove a print line
pengdurice fbc7a7d
remove a print line
pengdurice 57fd917
rebase on main and then smoothout again
pengdurice a636341
fix the wiring of linear ce fusion
pengdurice fc199e5
address comments.
pengdurice 3e10e27
add nightly config and sh files and tested locally
pengdurice e314b90
Update nemo_rl/models/megatron/setup.py
pengdurice 71e5275
Update nemo_rl/algorithms/sft.py
pengdurice a18b24d
save local and rebase upstream
pengdurice de5ee1f
fix according to comments, maybe need some more
pengdurice f278ada
address more comments
pengdurice 72a7254
Apply suggestions from code review
pengdurice 86fd0b0
address comments and cleaning up
pengdurice 797ee8d
remove local test env setup
pengdurice 0485dee
some more clean up
pengdurice 8296c6d
Update nemo_rl/models/megatron/setup.py
pengdurice fb26086
address comments
pengdurice b96b569
Merge branch 'main' into peng-add-linear-ce-fusion-v1
yuki-97 de97d32
fix ruff-format issues
pengdurice eabe55d
Update nemo_rl/models/megatron/setup.py
pengdurice 751ccb0
Update nemo_rl/models/policy/__init__.py
pengdurice a6cee3a
Update nemo_rl/models/megatron/setup.py
pengdurice c8b0a97
run pre-commit, also change another place for accessing use_linear_ce…
pengdurice 74bdffb
Apply suggestion
yuki-97 c87b344
add nightly fix
pengdurice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.