Skip to content

fix: Fix adv estimator configs #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Feb 21, 2026
Merged

fix: Fix adv estimator configs #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/configs/grpo_math_1B.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ grpo:
# Options: "grpo" (default) or "reinforce_plus_plus"
adv_estimator:
name: "grpo" # Use "reinforce_plus_plus" for Reinforce++ estimator
normalize_rewards: true
use_leave_one_out_baseline: false
normalize_rewards: ${grpo.normalize_rewards}
use_leave_one_out_baseline: ${grpo.use_leave_one_out_baseline}
minus_baseline: true # Reinforce++-baseline specific: subtract per-prompt mean baseline
reward_scaling:
enabled: false
Expand Down
4 changes: 2 additions & 2 deletions examples/configs/vlm_grpo_3B.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ grpo:
# Options: "grpo" (default) or "reinforce_plus_plus"
adv_estimator:
name: "grpo" # Use "reinforce_plus_plus" for Reinforce++ estimator
normalize_rewards: true
use_leave_one_out_baseline: false
normalize_rewards: ${grpo.normalize_rewards}
use_leave_one_out_baseline: ${grpo.use_leave_one_out_baseline}
minus_baseline: true # Reinforce++-baseline specific: subtract per-prompt mean baseline
reward_scaling:
enabled: false
Expand Down
4 changes: 2 additions & 2 deletions examples/configs/vlm_grpo_3B_megatron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ grpo:
# Options: "grpo" (default) or "reinforce_plus_plus"
adv_estimator:
name: "grpo" # Use "reinforce_plus_plus" for Reinforce++ estimator
normalize_rewards: true
use_leave_one_out_baseline: false
normalize_rewards: ${grpo.normalize_rewards}
use_leave_one_out_baseline: ${grpo.use_leave_one_out_baseline}
minus_baseline: true # Reinforce++-baseline specific: subtract per-prompt mean baseline
reward_scaling:
enabled: false
Expand Down
4 changes: 2 additions & 2 deletions examples/nemo_gym/grpo_workplace_assistant_nemotron_nano_v2_9b.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ grpo:
# Options: "grpo" (default) or "reinforce_plus_plus"
adv_estimator:
name: "grpo" # Use "reinforce_plus_plus" for Reinforce++ estimator
normalize_rewards: true
use_leave_one_out_baseline: false
normalize_rewards: ${grpo.normalize_rewards}
use_leave_one_out_baseline: ${grpo.use_leave_one_out_baseline}
minus_baseline: true # Reinforce++-baseline specific: subtract per-prompt mean baseline
reward_scaling:
enabled: false
Expand Down
4 changes: 2 additions & 2 deletions research/template_project/configs/grpo_math_1B.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ grpo:
# Options: "grpo" (default) or "reinforce_plus_plus"
adv_estimator:
name: "grpo" # Use "reinforce_plus_plus" for Reinforce++ estimator
normalize_rewards: true
use_leave_one_out_baseline: false
normalize_rewards: ${grpo.normalize_rewards}
use_leave_one_out_baseline: ${grpo.use_leave_one_out_baseline}
minus_baseline: true # Reinforce++-baseline specific: subtract per-prompt mean baseline
async_grpo:
enabled: false # Set to true to enable async training mode
Expand Down
Loading