Skip to content

feat: add way of excluding generation backends and disable sglang tests in CI#1855

Merged
terrykong merged 3 commits intomainfrom
tk/backend-spec
Feb 9, 2026
Merged

feat: add way of excluding generation backends and disable sglang tests in CI#1855
terrykong merged 3 commits intomainfrom
tk/backend-spec

Conversation

@terrykong
Copy link
Collaborator

@terrykong terrykong commented Jan 31, 2026

@nathan-az

Summary by CodeRabbit

Release Notes

  • New Features

    • Added optional build flags to skip vLLM and SGLang dependencies, reducing build time and image size.
    • Introduced filtering capabilities for dependency prefetching with new CLI options.
  • Documentation

    • Restructured Docker build guide with clearer multi-line commands and improved formatting.
    • Added dedicated section documenting how to skip optional dependencies during image builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@terrykong terrykong requested review from a team as code owners January 31, 2026 06:04
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 31, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

This change introduces conditional build-time flags (SKIP_VLLM_BUILD and SKIP_SGLANG_BUILD) to optionally skip vLLM and SGLang dependency installation during Docker builds, along with updated documentation and utility functions to support negative filtering in dependency prefetching.

Changes

Cohort / File(s) Summary
Docker Build Configuration
docker/Dockerfile
Added SKIP_VLLM_BUILD and SKIP_SGLANG_BUILD build arguments; replaced unconditional uv sync calls with conditional logic gated by these flags; updated prefetch_venvs invocation to pass corresponding --negative-filters arguments based on flag values.
Docker Documentation
docs/docker.md
Reworded guide focus to NeMo RL image building; replaced Release/Hermetic section with simplified multi-line docker buildx examples; added new "Skipping vLLM or SGLang Dependencies" section documenting SKIP_VLLM_BUILD and SKIP_SGLANG_BUILD usage with command variants and runtime caveats.
Prefetch Utilities
nemo_rl/utils/prefetch_venvs.py
Added optional negative_filters parameter to prefetch_venvs function to exclude actors from prefetching; integrated filter logic into main loop with exclusion tracking; extended CLI with new --negative-filters option supporting multiple values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR introduces major features but PR description lacks test results, testing information, and performance metrics documentation. Update PR description with unit test results, Docker build test results, image size comparisons, and add test cases for the new negative_filters parameter.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title accurately describes the main changes: adding mechanisms to exclude/skip generation backends (vLLM and SGLang) and mentions disabling sgLang tests in CI.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tk/backend-spec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong requested a review from chtruong814 February 3, 2026 18:20
@terrykong terrykong added the CI:L1 Run doctests, unit tests, and functional tests label Feb 7, 2026
@terrykong terrykong enabled auto-merge (squash) February 7, 2026 23:54
Copy link
Collaborator Author

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chtruong814 to review

chtruong814
chtruong814 previously approved these changes Feb 8, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
@yuki-97 yuki-97 requested a review from a team as a code owner February 9, 2026 09:21
@github-actions github-actions bot added the CI Relating to CI label Feb 9, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Feb 9, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Feb 9, 2026
@yuki-97 yuki-97 changed the title feat: add way of excluding generation backends feat: add way of excluding generation backends and temporarily disable sglang tests in CI Feb 9, 2026
@yuki-97 yuki-97 changed the title feat: add way of excluding generation backends and temporarily disable sglang tests in CI feat: add way of excluding generation backends and disable sglang tests in CI Feb 9, 2026
@terrykong terrykong merged commit e48d2d2 into main Feb 9, 2026
92 of 111 checks passed
@terrykong terrykong deleted the tk/backend-spec branch February 9, 2026 17:01
chtruong814 pushed a commit that referenced this pull request Feb 11, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests CI Relating to CI documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants