Skip to content

fix: remove seq_parallel + tp restriction in dtensor v2 #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terrykong wants to merge 1 commit into from
Closed

fix: remove seq_parallel + tp restriction in dtensor v2 #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions nemo_rl/models/policy/workers/dtensor_policy_worker_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,10 +324,6 @@ def __init__(
print(
"[WARNING]: sequence_parallel=True, but tp_size=1 which has no effect. Enable tp_size > 1 to use sequence parallelism."
)
elif sequence_parallel_enabled and tp_size > 1:
Copy link
Copy Markdown
Contributor

@yuki-97 yuki-97 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also remove this restriction in dtensor v1?

raise RuntimeError(
"Sequence parallel + tp_size >1 is currently broken in torch==2.8.0. See https://github.com/NVIDIA-NeMo/Automodel/issues/652 for more details."
)

if cp_size > 1:
assert not isinstance(self.model, Gemma3ForCausalLM), (
Expand Down
Loading