Skip to content

fix: log metrics that can be coerced to scalars#1723

Merged
yuki-97 merged 1 commit intomainfrom
test-fixes-6
Jan 6, 2026
Merged

fix: log metrics that can be coerced to scalars#1723
yuki-97 merged 1 commit intomainfrom
test-fixes-6

Conversation

@terrykong
Copy link
Copy Markdown
Collaborator

@terrykong terrykong commented Jan 6, 2026

What does this PR do ?

previously some val metrics were skipped because a change to the logger skipped over things that were tensors (but looked like scalars)

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested review from yfw and yuki-97 January 6, 2026 08:33
@terrykong terrykong requested review from a team as code owners January 6, 2026 08:33
@terrykong terrykong added CI:L1 Run doctests, unit tests, and functional tests r0.5.0 labels Jan 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 6, 2026

Warning

Rate limit exceeded

@terrykong has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1720466 and 374a94f.

📒 Files selected for processing (2)
  • nemo_rl/utils/logger.py
  • tests/unit/utils/test_logger.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong mentioned this pull request Jan 6, 2026
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 6, 2026
@yuki-97 yuki-97 enabled auto-merge (squash) January 6, 2026 10:55
@yuki-97 yuki-97 merged commit 932c72d into main Jan 6, 2026
64 of 71 checks passed
@yuki-97 yuki-97 deleted the test-fixes-6 branch January 6, 2026 22:36
chtruong814 pushed a commit that referenced this pull request Jan 6, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
parthmannan pushed a commit to parthmannan/RL that referenced this pull request Jan 15, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests r0.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants