Skip to content

fix: always test vllm #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Apr 11, 2025
Merged

fix: always test vllm #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions tests/unit/models/generation/test_vllm_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,6 @@
}


@pytest.fixture(scope="module")
def check_vllm_available():
"""Skip tests if vLLM is not installed."""
try:
import vllm # noqa: F401
except ImportError:
pytest.skip("vLLM not installed")


@pytest.fixture(scope="module")
def cluster():
"""Create a virtual cluster for testing."""
Expand All @@ -76,7 +67,7 @@ def tokenizer():


@pytest.fixture(scope="function")
def policy(cluster, tokenizer, check_vllm_available):
def policy(cluster, tokenizer):
"""Initialize the vLLM policy."""
# Create separate configs for each policy
vllm_config = basic_vllm_test_config.copy()
Expand Down Expand Up @@ -126,7 +117,7 @@ def test_input_data(tokenizer):
)


def test_vllm_missing_required_config_key(cluster, check_vllm_available):
def test_vllm_missing_required_config_key(cluster):
"""Test that an assertion error is raised when a required config key is missing."""
# Create a config missing a required key by removing 'model_name'
incomplete_config = basic_vllm_test_config.copy()
Expand Down