chore: fix grpo functional test metric#1643
Merged
Conversation
Signed-off-by: ruit <ruit@nvidia.com>
Contributor
📝 WalkthroughWalkthroughA test threshold expectation is adjusted in the GRPO test suite, reducing the maximum tolerance for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yuki-97
approved these changes
Dec 16, 2025
terrykong
approved these changes
Dec 16, 2025
DeL-TaiseiOzaki
pushed a commit
to DeL-TaiseiOzaki/RL
that referenced
this pull request
Jan 8, 2026
Signed-off-by: ruit <ruit@nvidia.com>
parthmannan
pushed a commit
to parthmannan/RL
that referenced
this pull request
Jan 15, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: Parth Mannan <pmannan@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 12, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 9, 2026
Signed-off-by: ruit <ruit@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Reduce the functional test acceptance threshold for train/gen_kl_error from 1.05 to 0.001 to catch subtle regressions in generation logprob/KL alignment early.
Related Context
Link: #1506 (comment)
gen_kl_error should actually be pretty low, usually we set it to be <1e-3.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.