Conversation
📝 WalkthroughWalkthroughUpdates submodule tracking for 3rdparty/Megatron-LM to use a new branch variant with yarn fix support. Adds new DAPO DeepSeek v3 performance configuration file and corresponding test script with environment setup, execution, and metrics evaluation logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bbd6933 to
70f7324
Compare
521b9ea to
679273f
Compare
|
@guyueh1 could you take a review? |
679273f to
3f841ff
Compare
|
@ZhiyuLi-Nvidia would you add this test to the tests/test_suites/performance_h100.txt? |
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
356a7db to
1d6eaa2
Compare
Thank you @guyueh1, just added. |
|
@ZhiyuLi-Nvidia is this ready? @guyueh1 to review |
Yeap. @guyueh1 I have address you comment to "add this test to the tests/test_suites/performance_h100.txt". Could you take another look? |
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Parth Mannan <pmannan@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
What does this PR do ?
Verified the test and recipe: https://wandb.ai/nvidia/nemo-rl/runs/ks1cpy6o/logs?nw=nwuserzhiyulUpdate test and recipe: https://wandb.ai/nvidia/nemo-rl/runs/g5r4xwvfUpdate test and recipe with 1.5k seq length: https://wandb.ai/nvidia/nemo-rl/runs/eobc39eb
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.