Skip to content

feat: Enable Ray dashboard for Ray state API#1602

Merged
terrykong merged 1 commit intomainfrom
pjin/ray-state-api
Dec 5, 2025
Merged

feat: Enable Ray dashboard for Ray state API#1602
terrykong merged 1 commit intomainfrom
pjin/ray-state-api

Conversation

@pjin-nvidia
Copy link
Contributor

@pjin-nvidia pjin-nvidia commented Dec 5, 2025

What does this PR do ?

This PR sets a non-localhost dashboard address when starting the Ray cluster via ray.sub to enable queries to the Ray state API (potentially used by e.g. Gym).

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Ray head node dashboard now binds to the head node IP address and is explicitly enabled in the start command.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Peter Jin <pjin@nvidia.com>
@pjin-nvidia pjin-nvidia requested a review from a team as a code owner December 5, 2025 00:12
@pjin-nvidia pjin-nvidia changed the title Enable Ray dashboard for Ray state API feat: Enable Ray dashboard for Ray state API Dec 5, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

Two flags are added to the head node Ray start command: --dashboard-host="$head_node_ip" and --include-dashboard=True. These explicitly configure dashboard exposure by setting the host IP and enabling dashboard inclusion.

Changes

Cohort / File(s) Change Summary
Ray head node dashboard configuration
ray.sub
Add --dashboard-host="$head_node_ip" and --include-dashboard=True flags to head node Ray start command

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Focus areas: Verify the flag syntax is correct for the Ray version in use and confirm the head node IP variable ($head_node_ip) is properly defined and populated in the script context.

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: enabling the Ray dashboard by adding dashboard-related flags to the head node Ray start command for Ray state API access.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor configuration changes (two flag additions) that qualify for exemption from test documentation requirements per custom check instructions.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pjin/ray-state-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a99bc26 and bea6d2b.

📒 Files selected for processing (1)
  • ray.sub (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
!(**/tests/**|**/test_*.py|**/test_*.sh)

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Add the NVIDIA copyright header to all Python files and shell scripts (excluding tests). The header should include the current year

Files:

  • ray.sub
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint check
  • GitHub Check: Post submodule check comment / Comment on PR
  • GitHub Check: Post automodel integration comment / Comment on PR

Copy link
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjin-nvidia is this so you can access using DNS of the slurm node and not have to hop onto and ssh port forward?

@pjin-nvidia
Copy link
Contributor Author

@pjin-nvidia is this so you can access using DNS of the slurm node and not have to hop onto and ssh port forward?

yeah, also it makes it easier to use ray.util.state APIs (e.g. https://docs.ray.io/en/latest/ray-observability/reference/doc/ray.util.state.list_nodes.html#ray.util.state.list_nodes) which I think work by querying the dashboard

@terrykong terrykong added the CI:docs Run doctest label Dec 5, 2025
@terrykong terrykong enabled auto-merge (squash) December 5, 2025 20:12
@terrykong terrykong merged commit 0947683 into main Dec 5, 2025
40 of 43 checks passed
@terrykong terrykong deleted the pjin/ray-state-api branch December 5, 2025 20:47
DeL-TaiseiOzaki pushed a commit to DeL-TaiseiOzaki/RL that referenced this pull request Jan 8, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Peter Jin <pjin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants