Skip to content

fix: Fixed dependency issue with NeMo Gym#1601

Closed
ahmadki wants to merge 1 commit intomainfrom
ahmadki/gym_dep_fix
Closed

fix: Fixed dependency issue with NeMo Gym#1601
ahmadki wants to merge 1 commit intomainfrom
ahmadki/gym_dep_fix

Conversation

@ahmadki
Copy link
Member

@ahmadki ahmadki commented Dec 4, 2025

What does this PR do ?

Fixed dependency issue with NeMo Gym

Summary by CodeRabbit

  • Chores
    • Updated system dependencies to enhance monitoring capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
@ahmadki ahmadki requested a review from a team as a code owner December 4, 2025 23:49
@ahmadki ahmadki changed the title Fixed dependency issue with NeMo Gym fix: Fixed dependency issue with NeMo Gym Dec 4, 2025
@ahmadki
Copy link
Member Author

ahmadki commented Dec 4, 2025

Just noticed this is included in #1587

@ahmadki ahmadki closed this Dec 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Added "psutil" to the CACHED_DEPENDENCIES list in the Penguin-workspace setup configuration file. This expands the set of dependencies verified against the submodule's pyproject.toml without modifying any logic.

Changes

Cohort / File(s) Change Summary
Dependency addition
3rdparty/Penguin-workspace/setup.py
Added "psutil" to CACHED_DEPENDENCIES list for dependency verification

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ahmadki/gym_dep_fix

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a99bc26 and d2e9ef7.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Penguin-workspace/setup.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant