Skip to content

refactor: refactor config matching from megatron-bridge #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youngeunkwon0405 wants to merge 1 commit into from
+4 −19
Closed

refactor: refactor config matching from megatron-bridge #1501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions nemo_rl/models/megatron/community_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,10 @@ def import_model_from_hf_name(
orig_pipeline_dtype = model_provider.pipeline_dtype

if megatron_config is not None:
model_provider.tensor_model_parallel_size = megatron_config[
"tensor_model_parallel_size"
]
model_provider.pipeline_model_parallel_size = megatron_config[
"pipeline_model_parallel_size"
]
model_provider.expert_model_parallel_size = megatron_config[
"expert_model_parallel_size"
]
model_provider.expert_tensor_parallel_size = megatron_config[
"expert_tensor_parallel_size"
]
model_provider.num_layers_in_first_pipeline_stage = megatron_config[
"num_layers_in_first_pipeline_stage"
]
model_provider.num_layers_in_last_pipeline_stage = megatron_config[
"num_layers_in_last_pipeline_stage"
]
model_provider.pipeline_dtype = megatron_config["pipeline_dtype"]
for k in megatron_config.keys():
if hasattr(model_provider, k):
setattr(model_provider, k, megatron_config[k]) # type: ignore

model_provider.finalize()
model_provider.initialize_model_parallel(seed=0)
megatron_model = model_provider.provide_distributed_model(wrap_with_ddp=False)
Expand Down
Loading