📝 Add docstrings to zhiyul/refit_zmq_refactor#1270
Closed
coderabbitai[bot] wants to merge 4 commits intozhiyul/refit_zmq_refactorfrom
Closed
📝 Add docstrings to zhiyul/refit_zmq_refactor#1270coderabbitai[bot] wants to merge 4 commits intozhiyul/refit_zmq_refactorfrom
zhiyul/refit_zmq_refactor#1270coderabbitai[bot] wants to merge 4 commits intozhiyul/refit_zmq_refactorfrom
Conversation
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Docstrings generation was requested by @ZhiyuLi-Nvidia. * #1267 (comment) The following files were modified: * `nemo_rl/algorithms/grpo.py` * `nemo_rl/models/generation/interfaces.py` * `nemo_rl/models/generation/vllm/vllm_backend.py` * `nemo_rl/models/generation/vllm/vllm_generation.py` * `nemo_rl/models/generation/vllm/vllm_worker.py` * `nemo_rl/models/generation/vllm/vllm_worker_async.py` * `nemo_rl/models/policy/dtensor_policy_worker.py` * `nemo_rl/models/policy/dtensor_policy_worker_v2.py` * `nemo_rl/models/policy/interfaces.py` * `nemo_rl/models/policy/lm_policy.py` * `nemo_rl/models/policy/megatron_policy_worker.py` * `nemo_rl/models/policy/utils.py`
4 tasks
ℹ️ File Consistency CheckCheck based on commit: 76776db (PR #1270 from ✅ DTensor Policy Worker Synchronization CheckBoth DTensor policy worker files were modified in this PR:
Please ensure that the changes are consistent between both files where applicable. This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning. |
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/refit_zmq_refactor
branch
from
73cfc13 to
b9f427b
Compare
ZhiyuLi-Nvidia
approved these changes
Oct 8, 2025
Contributor
|
Merge manually along with some changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @ZhiyuLi-Nvidia.
The following files were modified:
nemo_rl/algorithms/grpo.pynemo_rl/models/generation/interfaces.pynemo_rl/models/generation/vllm/vllm_backend.pynemo_rl/models/generation/vllm/vllm_generation.pynemo_rl/models/generation/vllm/vllm_worker.pynemo_rl/models/generation/vllm/vllm_worker_async.pynemo_rl/models/policy/dtensor_policy_worker.pynemo_rl/models/policy/dtensor_policy_worker_v2.pynemo_rl/models/policy/interfaces.pynemo_rl/models/policy/lm_policy.pynemo_rl/models/policy/megatron_policy_worker.pynemo_rl/models/policy/utils.pyThese file types are not supported
pyproject.tomlℹ️ Note