Skip to content

fix: issue where generation_weight_version isn't correct after refit #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthchadha merged 2 commits into from
Sep 3, 2025
Merged

fix: issue where generation_weight_version isn't correct after refit #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f4f9c
fix: issue where generation_weight_version isn't correct after refit
Sep 2, 2025
a104528
Merge branch 'faster-strictfifo' into faster-strictfifo-refit-wfix
youngeunkwon0405 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nemo_rl/algorithms/async_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,9 @@ def _process_batch(self, batch: BatchedDataDict[DatumSpec]) -> None:
f"⏸️ Waiting for refit to complete before starting new generation ({active_threads} threads still active)"
)
self._refit_pause_cleared.wait()

# After refit finishes if weight version has updated, reflect that in the new trajectories
generation_weight_version = self.current_weight_version

single_prompt_batch = batch.slice(prompt_idx, prompt_idx + 1)
repeated_batch = single_prompt_batch.repeat_interleave(num_generations)
Expand Down
11 changes: 6 additions & 5 deletions nemo_rl/algorithms/grpo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,11 +1487,12 @@ def async_grpo_train(
)
POLICY_GENERATION_STALE = False

trajectory_collector.resume_after_refit.remote()

# Notify collector about the new weight version (post-update)
weight_version += 1
trajectory_collector.set_weight_version.remote(weight_version)
#Update weight version before resuming trajectory collection so that all trajectories are updated with the new correct weight version
weight_version += 1
trajectory_collector.set_weight_version.remote(weight_version)
trajectory_collector.resume_after_refit.remote()



# Validation
val_metrics, validation_timings = None, None
Expand Down