fix: ray.sub will exit early if any srun fails to launch #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
This reverts commit 63e2f6a. Signed-off-by: Terry Kong <[email protected]>
This reverts commit c7ad390. Signed-off-by: Terry Kong <[email protected]>
Example output: ``` + echo '[ERROR] Background srun '\''ray-worker-1'\'' died (pid=123456). Could be a failure in startup or an issue with the node preventing the srun to start. Attempting to exit.' [ERROR] Background srun 'ray-worker-1' died (pid=123456). Could be a failure in startup or an issue with the node preventing the srun to start. Attempting to exit. + touch /logdir/5336464-logs/ENDED + exit 1 ``` Signed-off-by: Terry Kong <[email protected]>
hemildesai
approved these changes
Sep 2, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Terry Kong <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
wangshangsam
pushed a commit
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Terry Kong <[email protected]> Signed-off-by: Shang Wang <[email protected]>
terrykong
added a commit
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Terry Kong <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo-RL
that referenced
this pull request
Sep 15, 2025
…#1022) Signed-off-by: Terry Kong <[email protected]>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…#1022) Signed-off-by: Terry Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1019
Example output: