Skip to content

chore: flush to stdout when print logging during GRPO#1021

Merged
terrykong merged 2 commits intomainfrom
pjin/print
Sep 2, 2025
Merged

chore: flush to stdout when print logging during GRPO#1021
terrykong merged 2 commits intomainfrom
pjin/print

Conversation

@pjin-nvidia
Copy link
Contributor

What does this PR do ?

Set flush=True in GRPO print logging so that ray worker logging (e.g. from VLLM generation workers) is interleaved w/ other logs in the correct order.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Peter Jin <pjin@nvidia.com>
Signed-off-by: Peter Jin <pjin@nvidia.com>
@terrykong terrykong added this pull request to the merge queue Aug 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 31, 2025
@terrykong terrykong added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 7c5efd8 Sep 2, 2025
21 checks passed
@terrykong terrykong deleted the pjin/print branch September 2, 2025 08:00
guyueh1 pushed a commit to guyueh1/NeMo-RL that referenced this pull request Sep 15, 2025
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants