Skip to content

fix: remove unused fp8 training args in config#1018

Merged
terrykong merged 1 commit intomainfrom
ashors/remove-unused-fp8
Aug 29, 2025
Merged

fix: remove unused fp8 training args in config#1018
terrykong merged 1 commit intomainfrom
ashors/remove-unused-fp8

Conversation

@ashors1
Copy link
Contributor

@ashors1 ashors1 commented Aug 29, 2025

What does this PR do ?

Removes the fp8 training args that were erroneously added to the SFT openmathinstruct config. These args are currently unused.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested a review from terrykong August 29, 2025 00:16
@terrykong terrykong added this pull request to the merge queue Aug 29, 2025
Merged via the queue into main with commit 157b254 Aug 29, 2025
21 checks passed
@terrykong terrykong deleted the ashors/remove-unused-fp8 branch August 29, 2025 14:50
skirdey-inflection pushed a commit to skirdey-inflection/RL that referenced this pull request Aug 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants