Skip to content

Conversation

@Slyne
Copy link
Contributor

@Slyne Slyne commented Oct 24, 2019

  1. Add character error rate
  2. Add get_aishell_data.py to download aishell data and process data
  3. Add jasper_aishell.py to train model
  4. Add jasper_aishell_infer.py to do inference
  5. Add ASR_Jasper_Mandarin_Tutorial.ipynb as a tutorial for mandarin

@okuchaiev okuchaiev requested a review from redoctopus October 24, 2019 17:45
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the tutorial file necessary? It's highly similar to the existing ASR-Jasper-Tutorial.ipynb, which we are planning on removing since we are revamping the tutorials.
Maybe a more specific Mandarin ASR tutorial could be useful in the future, though I think that would be more focused on the differences between Mandarin and English ASR than a second version of the English tutorial.
@okuchaiev any thoughts?

@Slyne
Copy link
Contributor Author

Slyne commented Oct 25, 2019

Is the tutorial file necessary? It's highly similar to the existing ASR-Jasper-Tutorial.ipynb, which we are planning on removing since we are revamping the tutorials.
Maybe a more specific Mandarin ASR tutorial could be useful in the future, though I think that would be more focused on the differences between Mandarin and English ASR than a second version of the English tutorial.
@okuchaiev any thoughts?

I also agree with that. Since mandarin asr is very similar to English version, maybe just jasper_aishell.py & jasper_aishell_infer.py are enough.

@Slyne
Copy link
Contributor Author

Slyne commented Oct 25, 2019

Use eval_metric to replace use_wer param.

@Slyne Slyne requested review from blisc and redoctopus October 25, 2019 05:11
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Removing notebook and approving.

blisc
blisc previously approved these changes Oct 25, 2019
@blisc blisc closed this Oct 25, 2019
@blisc blisc mentioned this pull request Oct 25, 2019
XuesongYang pushed a commit to XuesongYang/NeMo that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants