-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add mandarin support #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Slyne
commented
Oct 24, 2019
- Add character error rate
- Add get_aishell_data.py to download aishell data and process data
- Add jasper_aishell.py to train model
- Add jasper_aishell_infer.py to do inference
- Add ASR_Jasper_Mandarin_Tutorial.ipynb as a tutorial for mandarin
redoctopus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the tutorial file necessary? It's highly similar to the existing ASR-Jasper-Tutorial.ipynb, which we are planning on removing since we are revamping the tutorials.
Maybe a more specific Mandarin ASR tutorial could be useful in the future, though I think that would be more focused on the differences between Mandarin and English ASR than a second version of the English tutorial.
@okuchaiev any thoughts?
I also agree with that. Since mandarin asr is very similar to English version, maybe just jasper_aishell.py & jasper_aishell_infer.py are enough. |
|
Use eval_metric to replace use_wer param. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Removing notebook and approving.
Signed-off-by: Ryan <[email protected]>