Add advanced tb logging options to eval. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
okuchaiev
approved these changes
Oct 24, 2019
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
chore: update exist check logic
blisc
pushed a commit
that referenced
this pull request
May 5, 2025
* Bugfix: num_audio_tokens_per_codebook
Make sure to reserve enough tokens for special uses like EOS/BOS.
WARNING: old models will be incompatible with the updated inference YAMLs
and will need to override the num_audio_tokens_per_codebook to the value they were
trained with.
* Rework how number of codes and codebooks are handled (WIP)
* Reorder the code a bit for clarity
* Refactor codebook configuration
* read codec parameters from codec checkpoint; remove corresponding configuration from Magpie YAML files
* add mechanism for backward compatibility with older checkpoints:
** If using `infer_and_evaluate.py`, just set the --legacy_codebooks command line flag
** If running training or inference with the Hydra command line, override using the following flags:
```
forced_num_all_tokens_per_codebook: 2048
forced_audio_bos_id: ${sum:${model.forced_num_all_tokens_per_codebook}, -1} # 2047
forced_audio_eos_id: ${sum:${model.forced_num_all_tokens_per_codebook}, -2} # 2046
forced_context_audio_bos_id: ${sum:${model.forced_num_all_tokens_per_codebook}, -4} # 2044
forced_context_audio_eos_id: ${sum:${model.forced_num_all_tokens_per_codebook}, -3} # 2045
```
* Add README on the codebook reorganization
... and how to load legacy checkpoints.
* Cleanup
* Cleanup and fixing typos
* Cleanup
* Cleanup
* Clarify the README on the embedding table layout
* README cleanup
* Rename an attritube for clarity
codec_model_downsample_factor --> codec_model_samples_per_frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.