Switch Jasper script to Cosine + max_steps bugfix #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Oleksii Kuchaiev <[email protected]>
blisc
reviewed
Oct 21, 2019
Signed-off-by: Oleksii Kuchaiev <[email protected]>
blisc
approved these changes
Oct 21, 2019
XuesongYang
pushed a commit
to XuesongYang/NeMo
that referenced
this pull request
Apr 21, 2025
* add fix to infer script Signed-off-by: Jason <[email protected]> * add no context option Signed-off-by: Jason <[email protected]> * add nemo option to infer script Signed-off-by: Jason <[email protected]> * add in latest bf16 changes from Edresson Signed-off-by: Jason <[email protected]> * add comment Signed-off-by: Jason <[email protected]> * enforce codec precision for now Signed-off-by: Jason <[email protected]> * fix autocast bug Signed-off-by: Jason <[email protected]> * another bug fix Signed-off-by: Jason <[email protected]> * clean PR Signed-off-by: Jason <[email protected]> * change hardcoded epsilon Signed-off-by: Jason <[email protected]> * infer changes Signed-off-by: Jason <[email protected]> * address review Signed-off-by: Jason <[email protected]> --------- Signed-off-by: Jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Jasper script to Cosine and allow num_epochs and max_steps
Fix issue when max_steps is specified it still wouldn't go above one epoch