Skip to content

Conversation

@matteolippi
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes a bug in the process_text method of MagpieTTS_ModelInference where str.replace() was being called without capturing the return value, making text normalization ineffective.

Collection: TTS

Changelog

  • Fixed lines 1114-1115 in nemo/collections/tts/models/magpietts.py to assign the return values of str.replace() calls back to single_space_text
  • This ensures that the text normalization for "h t t p" → "http" and "w w w" → "www" actually takes effect during ASR transcript processing

Usage

No usage changes - this is an internal bug fix that makes existing functionality work as intended.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

For TTS changes: @blisc or @okuchaiev

Additional Information

none

@github-actions github-actions bot added the TTS label Nov 4, 2025
@blisc
Copy link
Collaborator

blisc commented Nov 4, 2025

Thanks for the bugfix! Let me fix it in #15010 since we moved the post-training classes to a different file.

@blisc blisc closed this Nov 4, 2025
blisc added a commit that referenced this pull request Nov 4, 2025
@matteolippi
Copy link
Author

Thanks for the bugfix! Let me fix it in #15010 since we moved the post-training classes to a different file.

No worries! In case I have other contributions, should I send the PR straight to magpietts_main?

@blisc
Copy link
Collaborator

blisc commented Nov 5, 2025

Thanks for the bugfix! Let me fix it in #15010 since we moved the post-training classes to a different file.

No worries! In case I have other contributions, should I send the PR straight to magpietts_main?

We plan to merge #15031 soon. Please send the PR to main branch after we merge.

@matteolippi
Copy link
Author

perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants