Update numba to numba-cuda and update cuda python bindings usage #15018
+62
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: chtruong814 <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: chtruong814 <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
This reverts commit 44c523b. Signed-off-by: Charlie Truong <[email protected]>
This reverts commit 3cb0150. Signed-off-by: Charlie Truong <[email protected]>
chtruong814
added
Run CICD
r2.6.0
thomasdhc
approved these changes
Nov 3, 2025
nithinraok
approved these changes
Nov 3, 2025
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
chtruong814
added a commit
that referenced
this pull request
Nov 3, 2025
) * Replace numba with numba-cuda[cu13] Signed-off-by: Charlie Truong <[email protected]> * Update cuda bindings ref for cuda 13 Signed-off-by: Charlie Truong <[email protected]> * Apply isort and black reformatting Signed-off-by: chtruong814 <[email protected]> * Use numba for mac Signed-off-by: Charlie Truong <[email protected]> * Fix numba check Signed-off-by: Charlie Truong <[email protected]> * Apply isort and black reformatting Signed-off-by: chtruong814 <[email protected]> * Fix cudart.cudaStreamGetCaptureInfo call for cuda 13 Signed-off-by: Charlie Truong <[email protected]> * Fix call to cuGraphAddNode Signed-off-by: Charlie Truong <[email protected]> * Test speech unit tests only Signed-off-by: Charlie Truong <[email protected]> * Skip main unit tests Signed-off-by: Charlie Truong <[email protected]> * Fix with_conditional_node cuda calls Signed-off-by: Charlie Truong <[email protected]> * Revert "Skip main unit tests" This reverts commit 44c523b. Signed-off-by: Charlie Truong <[email protected]> * Revert "Test speech unit tests only" This reverts commit 3cb0150. Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: chtruong814 <[email protected]> Co-authored-by: chtruong814 <[email protected]> Signed-off-by: NeMo Bot <[email protected]>
chtruong814
added a commit
that referenced
this pull request
Nov 4, 2025
) (#15024) * Replace numba with numba-cuda[cu13] * Update cuda bindings ref for cuda 13 * Apply isort and black reformatting * Use numba for mac * Fix numba check * Apply isort and black reformatting * Fix cudart.cudaStreamGetCaptureInfo call for cuda 13 * Fix call to cuGraphAddNode * Test speech unit tests only * Skip main unit tests * Fix with_conditional_node cuda calls * Revert "Skip main unit tests" This reverts commit 44c523b. * Revert "Test speech unit tests only" This reverts commit 3cb0150. --------- Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: chtruong814 <[email protected]> Signed-off-by: NeMo Bot <[email protected]> Co-authored-by: chtruong814 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Update numba to numba-cuda and update cuda python bindings usage
Related issues:
cuda-bindings(a.k.acuda-python) module layout has changed #14915Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information