Skip to content

Conversation

@Agoniii
Copy link
Contributor

@Agoniii Agoniii commented May 12, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Add Qwen2.5 VL
Please use with Mcore: NVIDIA/Megatron-LM#1591

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Agoniii <[email protected]>
@ntajbakhsh ntajbakhsh requested a review from cuichenx May 13, 2025 20:52
Agoniii and others added 2 commits May 20, 2025 21:06
Signed-off-by: Agoniii <[email protected]>
@cuichenx cuichenx self-assigned this May 21, 2025
cuichenx and others added 2 commits May 21, 2025 15:01
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jun 26, 2025
@cuichenx cuichenx removed the stale label Jun 26, 2025
cuichenx and others added 8 commits June 27, 2025 05:51
Signed-off-by: Chen Cui <[email protected]>
…en2.5vl

# Conflicts:
#	nemo/collections/vlm/qwen2vl/model/vision.py
Signed-off-by: Chen Cui <[email protected]>
@cuichenx cuichenx added Run CICD r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 labels Jun 26, 2025
Signed-off-by: Chen Cui <[email protected]>
@ko3n1g ko3n1g removed the Run CICD label Jun 26, 2025
Signed-off-by: Chen Cui <[email protected]>
@cuichenx cuichenx merged commit 59f4607 into NVIDIA-NeMo:main Jun 30, 2025
224 of 225 checks passed
ko3n1g pushed a commit that referenced this pull request Jun 30, 2025
* support qwen2.5-vl

Signed-off-by: Agoniii <[email protected]>

* update

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* fix vision projection config

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* add HFQwen25VLExporter

Signed-off-by: Agoniii <[email protected]>

* merge qwen2vl and qwen25vl into one folder

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* update Qwen25VLVisionTransformerBlock and packed_seq_params

Signed-off-by: Agoniii <[email protected]>

* add model configs

Signed-off-by: Chen Cui <[email protected]>

* add vision transformer block

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* ffn size for 32b and 72b

Signed-off-by: Chen Cui <[email protected]>

* misc fixes

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* linting

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* unintended qwen2 change

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Co-authored-by: cuichenx <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
* support qwen2.5-vl

Signed-off-by: Agoniii <[email protected]>

* update

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* fix vision projection config

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* add HFQwen25VLExporter

Signed-off-by: Agoniii <[email protected]>

* merge qwen2vl and qwen25vl into one folder

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* update Qwen25VLVisionTransformerBlock and packed_seq_params

Signed-off-by: Agoniii <[email protected]>

* add model configs

Signed-off-by: Chen Cui <[email protected]>

* add vision transformer block

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* ffn size for 32b and 72b

Signed-off-by: Chen Cui <[email protected]>

* misc fixes

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* linting

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* unintended qwen2 change

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Co-authored-by: cuichenx <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* support qwen2.5-vl

Signed-off-by: Agoniii <[email protected]>

* update

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* fix vision projection config

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* add HFQwen25VLExporter

Signed-off-by: Agoniii <[email protected]>

* merge qwen2vl and qwen25vl into one folder

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* update Qwen25VLVisionTransformerBlock and packed_seq_params

Signed-off-by: Agoniii <[email protected]>

* add model configs

Signed-off-by: Chen Cui <[email protected]>

* add vision transformer block

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* ffn size for 32b and 72b

Signed-off-by: Chen Cui <[email protected]>

* misc fixes

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* linting

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* unintended qwen2 change

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Co-authored-by: cuichenx <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* support qwen2.5-vl

Signed-off-by: Agoniii <[email protected]>

* update

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* fix vision projection config

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* add HFQwen25VLExporter

Signed-off-by: Agoniii <[email protected]>

* merge qwen2vl and qwen25vl into one folder

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* update Qwen25VLVisionTransformerBlock and packed_seq_params

Signed-off-by: Agoniii <[email protected]>

* add model configs

Signed-off-by: Chen Cui <[email protected]>

* add vision transformer block

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* ffn size for 32b and 72b

Signed-off-by: Chen Cui <[email protected]>

* misc fixes

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* linting

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* unintended qwen2 change

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Co-authored-by: cuichenx <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* support qwen2.5-vl

Signed-off-by: Agoniii <[email protected]>

* update

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* fix vision projection config

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* add HFQwen25VLExporter

Signed-off-by: Agoniii <[email protected]>

* merge qwen2vl and qwen25vl into one folder

Signed-off-by: Agoniii <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Agoniii <[email protected]>

* update Qwen25VLVisionTransformerBlock and packed_seq_params

Signed-off-by: Agoniii <[email protected]>

* add model configs

Signed-off-by: Chen Cui <[email protected]>

* add vision transformer block

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* ffn size for 32b and 72b

Signed-off-by: Chen Cui <[email protected]>

* misc fixes

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* linting

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* unintended qwen2 change

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Agoniii <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Co-authored-by: cuichenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants