Skip to content

Clean up fusion checks - #938

Merged
ananthsub merged 5 commits into
NVIDIA-NeMo:mainfrom
ananthsub:clean-up-fusion-checks
Oct 28, 2025
Merged

Clean up fusion checks#938
ananthsub merged 5 commits into
NVIDIA-NeMo:mainfrom
ananthsub:clean-up-fusion-checks

Conversation

@ananthsub

Copy link
Copy Markdown
Contributor

fix #437

@copy-pr-bot

copy-pr-bot Bot commented Oct 13, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 4c2bf15

@maanug-nv

Copy link
Copy Markdown
Contributor

can we also cleanup validate_rope_fusion_compatibility(), has some similar checks about TE version. We could instead maybe add this check there, not sure if we already have it.

@ananthsub
ananthsub force-pushed the clean-up-fusion-checks branch from 4c2bf15 to 168ca28 Compare October 20, 2025 18:51
@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 168ca28

@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 4194b14

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@ananthsub
ananthsub force-pushed the clean-up-fusion-checks branch from a12b2a7 to 3bdc15f Compare October 28, 2025 00:19
@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 3bdc15f

@ananthsub
ananthsub enabled auto-merge (squash) October 28, 2025 00:49
@ananthsub
ananthsub merged commit 07b106f into NVIDIA-NeMo:main Oct 28, 2025
27 of 28 checks passed
chtruong814 pushed a commit that referenced this pull request Oct 28, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
paul-gibbons pushed a commit to paul-gibbons/Megatron-Bridge that referenced this pull request Oct 29, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
paul-gibbons pushed a commit to paul-gibbons/Megatron-Bridge that referenced this pull request Oct 29, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
nv-mollys pushed a commit that referenced this pull request Oct 31, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: mollys <mollys@mollys.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.2.0 Cherry-pick label for r0.2.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up fusion checks

3 participants