Gemma3 Provider & Bridge - #867
Merged
Merged
Conversation
Signed-off-by: Ao Tang <aot@nvidia.com>
- Renamed `Gemma3ModelProvider` to `GemmaModelProvider` across multiple files for consistency. - Updated the mapping logic in `GemmaModelBridge` to use a dictionary for better readability and maintainability. - Adjusted imports to reflect the new provider name. Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
…t/gemma3-provider Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Contributor
Author
|
/ok to test 12d96b5 |
Signed-off-by: Ao Tang <aot@nvidia.com>
Contributor
Author
|
/ok to test 088fe9a |
yaoyu-33
reviewed
Oct 3, 2025
| f"layers.{local_layer_number}.", | ||
| f"layers.{global_layer_number}.", | ||
| ) | ||
| if isinstance(layer_module, TransformerLayer): |
Contributor
Author
There was a problem hiding this comment.
Non Mcore models does not neccessary have this attribute: e.g. The vision encoder for gemma3 (even tho it is not sharded)
yaoyu-33
reviewed
Oct 3, 2025
yaoyu-33
reviewed
Oct 3, 2025
ananthsub
approved these changes
Oct 13, 2025
Signed-off-by: Ao Tang <aot@nvidia.com>
Contributor
Author
|
/ok to test 148e3d0 |
Signed-off-by: Ao Tang <aot@nvidia.com>
Contributor
Author
|
/ok to test 019e81d |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #147