fix(nemotron-omni): accept dense decoder masks - #5181
Closed
jinglinglingling wants to merge 1 commit into
Closed
Conversation
jinglinglingling
force-pushed
the
linglinj/nemotron-omni-dense-mask-3290
branch
from
July 30, 2026 03:41
cb2589d to
7bfe219
Compare
7 tasks
jinglinglingling
force-pushed
the
linglinj/nemotron-omni-dense-mask-3290
branch
from
July 30, 2026 03:44
7bfe219 to
8e1523d
Compare
yaoyu-33
added
area:model
jinglinglingling
force-pushed
the
linglinj/nemotron-omni-dense-mask-3290
branch
from
August 5, 2026 00:31
8e1523d to
f8976cf
Compare
Keep media placeholder detection token-aligned when NeMo-RL provides a dense causal mask on the unpacked path. Signed-off-by: Linglin Jing <linglinj@cw-dfw-cs-001-vscode-01.cm.cluster>
jinglinglingling
force-pushed
the
linglinj/nemotron-omni-dense-mask-3290
branch
from
August 5, 2026 00:57
f8976cf to
2a3550d
Compare
Author
|
Rebased the dense decoder-mask fix onto current MBridge |
3 tasks
cuichenx
approved these changes
Aug 6, 2026
Contributor
|
/ok to test 2a3550d |
cuichenx
added
ready-to-merge
Contributor
|
/ok to test 2a3550d |
Contributor
|
@jinglinglingling can you take a look at #5304 which solves the same problem |
cuichenx
marked this pull request as draft
August 7, 2026 20:53
Contributor
|
Superseded by #5304, which has now merged. Closing this duplicate implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
ruff checkon the changed model and test filesruff format --checkon the changed model and test files