Support GLM5.2 and recipe for GLM 5.1 & 5.2 on GB200 and H100 - #4520
Merged
Conversation
9 tasks
Contributor
Author
|
/claude review |
Contributor
Review - GLM-5.2 support + GLM-5.1/5.2 perf recipesOverall clean and well-tested. One blocking bug in the tests. [High] Arithmetic assertion is wrong and will fail CI - tests/unit_tests/recipes/test_glm5_perf_recipes.py lines 127-135. The GLM-5.2 H100 recipe sets PP=13, EP=16, ETP=1, so 416 // (13161) = 416 // 208 = 2, but the test asserts == 4. The recipe is self-consistent (dense DP = 416 // (TPPPCP) = 416 // 208 = 2, expert DP = 416 // (PPEPETP) = 2), so the expected value should be 2. Inline suggestion posted. As written, this test fails and the whole file errors out. Notes (non-blocking):
Suggested test cases:
|
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
yaoyu-33
approved these changes
Jul 9, 2026
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Support GLM5.2 and use correct GLM5.x related flags, as introduced in NVIDIA/Megatron-LM#5246 and related PRs.
Changelog
GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information