cp: backport Nemotron 3 Ultra PRs into r0.5.0 - #4473
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Chen Cui <chcui@nvidia.com> (cherry picked from commit 9bfa760)
Signed-off-by: Chen Cui <chcui@nvidia.com> (cherry picked from commit 0917258)
Signed-off-by: Chen Cui <chcui@nvidia.com> (cherry picked from commit 1d0dab6)
Signed-off-by: Chen Cui <chcui@nvidia.com> (cherry picked from commit b35a97b)
a41bc8c to
461fff5
Compare
|
/ok to test 461fff5 |
Light Code ReviewCritical Bug PackedPerExpertLinear.sharded_state_dict missing required pg_collection kwarg (src/megatron/bridge/peft/utils.py:2261-2263) _make_grouped_expert_sharded_tensor now requires pg_collection as a keyword argument (it has no default value), but PackedPerExpertLinear.sharded_state_dict() does not pass it. This will raise TypeError at runtime when checkpointing any SharedOuterGroupedExpertAdapter. The fix is to either pass pg_collection=None (falls back to size-1 defaults) or thread the real collection from the owning adapter. See inline comment for a minimal fix suggestion. Missing Test Coverage
Suggested test cases No perf tests impacted. |
Signed-off-by: Chen Cui <chcui@nvidia.com>
Summary
Backports the Nemotron Ultra stack requested for
r0.5.0as one draft PR.Included cherry-picks:
feat(conversion): support distributed adapter exportfix(checkpointing): include optimizer scaffold while loadingfeat(scripts): add Ultra script prerequisitesfeat(nemotronh): add Nemotron 3 Ultra recipes and examplesExcluded after correction:
Validation
git diff --check origin/r0.5.0...HEADbash -nfor the Ultra example shell scriptsuv run --no-sync python -m py_compilefor touched Python scripts, recipe, and testspre-commit run --all-filesNotes:
uv run pre-commit run --all-filescould not resolve the release branch env on this host becausenvidia-resiliency-ext==0.6.0has no compatible wheel for this platform; directpre-commitpassed.torchduring unit-test conftest import.