Skip to content

[skills] chore: rename core skills with nemo mbridge prefix - #4026

Merged
cuichenx merged 2 commits into
mainfrom
chore/sign-nemo-mbridge-batch-01
May 29, 2026
Merged

[skills] chore: rename core skills with nemo mbridge prefix#4026
cuichenx merged 2 commits into
mainfrom
chore/sign-nemo-mbridge-batch-01

Conversation

@cuichenx

@cuichenx cuichenx commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Rename the first 3 public skills to the nemo-mbridge-* prefix:
    • nemo-mbridge-recipe-recommender
    • nemo-mbridge-mlm-bridge-training
    • nemo-mbridge-multi-node-slurm
  • Add/keep license: Apache-2.0 frontmatter for these public skills.
  • Add placeholder evals/evals.json files where needed for NVSkills signing.
  • Drop stale generated signature/card artifacts from the previously signed recipe skill so NVSkills can regenerate them for the new name.
  • Move the multi-node Slurm full template into references/templates.md and include it in docs/skills-index.md to keep SKILL.md under 500 lines without losing content.

Validation

  • Verified selected public skill directory names match SKILL.md frontmatter names.
  • Verified selected public skills have license: Apache-2.0.
  • Verified selected public skills have valid placeholder evals/evals.json files.
  • Verified selected public root SKILL.md files are <= 500 lines.
  • git diff --check passed.
  • uv run --no-sync pre-commit run --all-files passed.

@cuichenx
[skills] rename core skills with nemo mbridge prefix
0b93319 
Signed-off-by: Chen Cui <chcui@nvidia.com>
@cuichenx

cuichenx commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@claude

claude Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Light Code Review -- Stale cross-references (bug): Two other skills still reference the old path which no longer exists after this rename: skills/nemo-rl-e2e-testing/SKILL.md:468 and skills/verl-e2e-testing/SKILL.md:434. Both reference @skills/multi-node-slurm/SKILL.md and should be updated to @skills/nemo-mbridge-multi-node-slurm/SKILL.md. -- card.yaml title not updated: skills/nemo-mbridge-mlm-bridge-training/card.yaml still has title: mlm_bridge_training. Consider updating to match the new skill name. -- Suggested test cases: No perf tests impacted.

@claude

claude Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Light Code Review

Stale cross-references (bug)

Two other skills still reference the old path, which no longer exists after this rename:

  • skills/nemo-rl-e2e-testing/SKILL.md:468
  • skills/verl-e2e-testing/SKILL.md:434

Both reference @skills/multi-node-slurm/SKILL.md -- should be updated to @skills/nemo-mbridge-multi-node-slurm/SKILL.md in this PR to avoid broken references.

card.yaml title not updated

skills/nemo-mbridge-mlm-bridge-training/card.yaml still has title: mlm_bridge_training. Consider updating it to match the new skill name for consistency.

Suggested test cases

No perf tests impacted.

@svc-nvskills-signing
Attach NVSkills validation signatures
f125af7 
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33 yaoyu-33 added area:misc Cross-cutting utilities, logging, helpers, and other changes docs Documentation-only updates or documentation debt waiting-on-customer Waiting on the original author to respond labels May 28, 2026
@cuichenx cuichenx added the docs-only With great power comes great responsibility. label May 28, 2026
@cuichenx cuichenx mentioned this pull request May 29, 2026
Merged
@cuichenx

cuichenx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test f125af7

@cuichenx
cuichenx merged commit 70826df into main May 29, 2026
36 checks passed
@cuichenx
cuichenx deleted the chore/sign-nemo-mbridge-batch-01 branch May 29, 2026 16:19
vasunvidia pushed a commit to vasunvidia/Megatron-Bridge that referenced this pull request Jun 10, 2026
@cuichenx @svc-nvskills-signing @vasunvidia
[skills] chore: rename core skills with nemo mbridge prefix (NVIDIA-N…
00190ee 
…eMo#4026)

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:misc Cross-cutting utilities, logging, helpers, and other changes docs Documentation-only updates or documentation debt docs-only With great power comes great responsibility. waiting-on-customer Waiting on the original author to respond

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cuichenx @yaoyu-33 @svc-nvskills-signing