[ci] fix: re-enable FSDP checkpoint test after TE 2.14 fix - #3485
Closed
yaoyu-33 wants to merge 2 commits into
Closed
[ci] fix: re-enable FSDP checkpoint test after TE 2.14 fix#3485yaoyu-33 wants to merge 2 commits into
yaoyu-33 wants to merge 2 commits into
Conversation
The test was marked `pleasefixme` due to a TE 2.14 regression where `split_swiglu_linear_fc1` validated the local FSDP shard shape instead of the global DTensor shape (NVIDIA/TransformerEngine#2795). Our TE pin (f031cf87 on release_v2.14) already includes the cherry-picked fix (a4a073b), so the marker can be removed. Closes: #2998 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 94154e8 |
Contributor
Author
|
/ok to test cb7eb10 |
yaoyu-33
added
ci
yaoyu-33
removed
the
ready-to-merge
Contributor
Author
|
no longer relevant since new fsdp tests added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pytest.mark.pleasefixmefromtest_fsdp_pretrain_with_checkpointsplit_swiglu_linear_fc1validated the local FSDP shard shape instead of the global DTensor shapef031cf87onrelease_v2.14) already includes the cherry-picked fix (a4a073b), so the marker can be safely removedCloses #2998
Test plan
test_fsdp_pretrain_with_checkpointinL0_Launch_training.shand it passes🤖 Generated with Claude Code