cp: fix(test): clone mmap-backed tensors before overwriting safetensors file (#3335) - #3441
Merged
Merged
Conversation
…ile (#3335) Cherry-pick of the safetensors fix from fd648d5 (main). _fuse_moe_expert_weights loads tensors via safetensors (memory-mapped), then writes back to the same file path. On some filesystems (e.g. Docker overlay in CI), this causes EFAULT because save_file truncates the file while the kept tensors still reference the mmap'd regions. Cloning the kept tensors before saving avoids this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fd648d56(main, PR chore(beep boop 🤖): Bumpuv.lock(main, mcore-main) (2026-04-15) #3335)_fuse_moe_expert_weightsloads tensors via safetensors (memory-mapped), then writes back to the same file path. On Docker overlay filesystems in CI, this causessafetensors_rust.SafetensorError: I/O error: Bad address (os error 14)becausesave_filetruncates the file while kept tensors still reference the mmap'd regionsv.clone())Test plan
🤖 Generated with Claude Code