-
Notifications
You must be signed in to change notification settings - Fork 467
[main] qwen-vl THD packed-sequence support and fixes #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
ea1af52
fix: align THD MoE aux-loss token accounting with valid tokens
DAISY-gh da9d926
fix: wire padding_mask through qwen3-vl gpt forward path
DAISY-gh 653dd62
fix: pass padding_mask into qwen gpt postprocess mtp path
DAISY-gh 88a8ac2
fix: update Megatron-LM pointer for main-based THD support
DAISY-gh 924497c
fix: make diffusion recipe imports optional
DAISY-gh 552282d
fix: guard optional deps for Qwen-VL recipe startup
DAISY-gh 2464771
feat: add qwen35_vl_35b_a3b_sft_energon_config recipe
DAISY-gh 7d4502d
fix: add packing_buffer_size to EnergonProvider and harden Qwen3VLPro…
DAISY-gh 9422407
feat: Add Energon THD packing support for QwenVL TaskEncoder and vlm_…
DAISY-gh 6af4f0f
feat: Add Energon SFT recipe for Qwen3.5-VL 35B-A3B with THD packing
DAISY-gh fd4215f
fix: QwenVLTaskBatch missing Energon 7.x __key__/__restore_key__ and …
DAISY-gh cfffa6a
fix: patch MTP attention with Qwen3VLSelfAttention for correct M-RoPE
DAISY-gh a6cd85f
fix: correctly pass padded/unpadded cu_seqlens for packed sequence TH…
DAISY-gh 1bafcda
fix: extend last segment boundary instead of adding zero-length paddi…
DAISY-gh be4105d
fix: use padded cu_seqlens for all fields following Megatron-LM data_…
DAISY-gh 32ae832
fix: compute MRoPE per sub-sequence for packed sequences to fix 22x l…
DAISY-gh 198b12e
fix: force Qwen-VL to recompute MRoPE in-model for THD
DAISY-gh cf7c7c5
fix: restore THD diagnostic helper symbols in Qwen3VL model
DAISY-gh cbeb228
fix: harden Energon QwenVL batch assembly for packed visual inputs
DAISY-gh 0f51a2c
fix: remove temporary THD debug logging noise
DAISY-gh c57be63
fix: gate THD diagnostics and remove hardcoded IterStats token id
DAISY-gh 8e07070
chore: add THD low-content dataloader diagnostics
DAISY-gh be70e4f
fix: wire THD runtime switches into vlm step paths
DAISY-gh 24b0503
fix: split packed boundaries for rope and kernels
DAISY-gh 583f185
fix: keep THD kernels padded while using unpadded rope boundaries
DAISY-gh 5813386
chore: add THD mask alignment diagnostics
DAISY-gh bacf813
fix: use explicit THD MoE padding mask
DAISY-gh 552d4a7
fix: cast attention mask to bool for THD mask remap
DAISY-gh d801e7b
chore: add THD label/loss alignment diagnostics
DAISY-gh bab9f91
chore: add THD MRoPE position diagnostics
DAISY-gh 10f6d78
fix: enforce bool masks for THD packed remap
DAISY-gh 03711a9
chore: add strict THD MRoPE remap check
DAISY-gh c68367c
chore: add THD boundary diagnostics switch
DAISY-gh 85a54c2
chore: clarify packed-seq boundary documentation
DAISY-gh 03ca9c7
feat: expose energon shuffle buffer override
DAISY-gh a0b5fd5
chore: sync nodebug training updates without submodule bump
DAISY-gh 0525c55
refactor: split batch-level and in-batch packing switches
DAISY-gh 0f5ee33
fix: disable packing defaults in energon recipe
DAISY-gh 2a018ec
fix: address optional import handling and recipe docs feedback
DAISY-gh 23d6bc3
fix: harden packed seqlens trimming and gate unsupported qwen3 batch-…
DAISY-gh 970e236
fix: address reviewer feedback for qwen-vl packing path
DAISY-gh 0b71929
docs: clarify in-batch vs batch-level packing semantics
DAISY-gh fcd0854
refactor: move qwen3-vl diag helpers into existing utils
DAISY-gh 34f8e58
chore: align Megatron-LM submodule pointer with main
DAISY-gh a85bce1
fix: enforce strict qwen-vl task encoder config sourcing
DAISY-gh 3880d0f
Merge branch 'main' into thd-support-main
yaoyu-33 e4a88ee
chore: ruff isort fix on merge-resolved files
yaoyu-33 50b5557
fix: resolve lint blockers in qwen-vl checks
DAISY-gh 5cfd9a9
Merge branch 'main' into thd-support-main
yaoyu-33 d2b73cc
style: ruff-format vlm_step.py after merge
yaoyu-33 db73764
refactor(vlm_step): use shared is_rank_0() helper instead of local _r…
yaoyu-33 b319cd1
style: ruff lint and format fixes
yaoyu-33 6c46f04
fix: restore qwen3-vl is_rank_0 re-export
DAISY-gh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The change intentionally narrows the optional-import fallback from broad
ExceptiontoImportError, so we do not mask unrelated runtime errors while still keeping graceful fallback when modelopt/scipy is unavailable. This keeps the quantized-export path optional but makes real failures visible in logs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still needed now that modelopt version is bumped?