chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-07) - #3191
Conversation
…-04-07) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test 909b3e5 |
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule pointer was bumped to commit
51ea688a5b7c98170d480185b60dc113de2d42d7 but the pin files used by
scripts/switch_mcore.sh (.main.commit and .dev.commit) still reference the old
commit ec458b67a3e8aa3a6f811df12d371c94eb18f392; update those pin files
(.main.commit and .dev.commit) to the new commit
51ea688a5b7c98170d480185b60dc113de2d42d7 in this PR so the switch_mcore.sh
script will not silently roll back the submodule pointer.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d4b8bc19-5b39-497a-93ca-f39e7dac7540
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit ec458b67a3e8aa3a6f811df12d371c94eb18f392 | |||
| Subproject commit 51ea688a5b7c98170d480185b60dc113de2d42d7 | |||
There was a problem hiding this comment.
Sync commit pin files with this submodule bump to avoid silent rollback.
Line 1 updates the submodule pointer, but scripts/switch_mcore.sh checks out commits from .main.commit / .dev.commit. With .main.commit still at ec458b67a3e8aa3a6f811df12d371c94eb18f392 (per provided snippet), running the switch script can revert this change. Please update the pin file(s) to 51ea688a5b7c98170d480185b60dc113de2d42d7 in the same PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, The submodule pointer was bumped to commit
51ea688a5b7c98170d480185b60dc113de2d42d7 but the pin files used by
scripts/switch_mcore.sh (.main.commit and .dev.commit) still reference the old
commit ec458b67a3e8aa3a6f811df12d371c94eb18f392; update those pin files
(.main.commit and .dev.commit) to the new commit
51ea688a5b7c98170d480185b60dc113de2d42d7 in this PR so the switch_mcore.sh
script will not silently roll back the submodule pointer.
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 2c79660 |
🚀 PR to bump
uv.lockinr0.4.0.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit