Skip to content

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-07) - #3191

Merged
ko3n1g merged 2 commits into
r0.4.0from
bump-ci-container-2026-04-07-r0.4.0-core_r0.17.0
Apr 8, 2026
Merged

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-07)#3191
ko3n1g merged 2 commits into
r0.4.0from
bump-ci-container-2026-04-07-r0.4.0-core_r0.17.0

Conversation

@svcnvidia-nemo-ci

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 PR to bump uv.lock in r0.4.0.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated the Megatron-LM library dependency to a newer version.

…-04-07)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test 909b3e5

@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the 3rdparty/Megatron-LM git submodule pointer to reference a newer commit (51ea688a5b7c98170d480185b60dc113de2d42d7 from ec458b67a3e8aa3a6f811df12d371c94eb18f392). This change updates the vendored Megatron-LM dependency version.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/Megatron-LM
Updated git submodule commit reference to newer version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
  • ananthsub
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title is unrelated to the changeset. The title mentions bumping 'uv.lock' and specific versions, but the actual change only updates a git submodule pointer for Megatron-LM. Update the title to accurately reflect the actual change, such as 'chore: Bump Megatron-LM submodule to commit 51ea688' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only a git submodule pointer update (1+1- lines) to bump Megatron-LM version. This is a minor change with low code review effort and no feature additions, breaking changes, or significant refactoring.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-07-r0.4.0-core_r0.17.0

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule pointer was bumped to commit
51ea688a5b7c98170d480185b60dc113de2d42d7 but the pin files used by
scripts/switch_mcore.sh (.main.commit and .dev.commit) still reference the old
commit ec458b67a3e8aa3a6f811df12d371c94eb18f392; update those pin files
(.main.commit and .dev.commit) to the new commit
51ea688a5b7c98170d480185b60dc113de2d42d7 in this PR so the switch_mcore.sh
script will not silently roll back the submodule pointer.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4b8bc19-5b39-497a-93ca-f39e7dac7540

📥 Commits

Reviewing files that changed from the base of the PR and between 9495c38 and 909b3e5.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

Comment thread 3rdparty/Megatron-LM
@@ -1 +1 @@
Subproject commit ec458b67a3e8aa3a6f811df12d371c94eb18f392
Subproject commit 51ea688a5b7c98170d480185b60dc113de2d42d7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Sync commit pin files with this submodule bump to avoid silent rollback.

Line 1 updates the submodule pointer, but scripts/switch_mcore.sh checks out commits from .main.commit / .dev.commit. With .main.commit still at ec458b67a3e8aa3a6f811df12d371c94eb18f392 (per provided snippet), running the switch script can revert this change. Please update the pin file(s) to 51ea688a5b7c98170d480185b60dc113de2d42d7 in the same PR.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule pointer was bumped to commit
51ea688a5b7c98170d480185b60dc113de2d42d7 but the pin files used by
scripts/switch_mcore.sh (.main.commit and .dev.commit) still reference the old
commit ec458b67a3e8aa3a6f811df12d371c94eb18f392; update those pin files
(.main.commit and .dev.commit) to the new commit
51ea688a5b7c98170d480185b60dc113de2d42d7 in this PR so the switch_mcore.sh
script will not silently roll back the submodule pointer.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

/ok to test 2c79660

@ko3n1g
ko3n1g merged commit be3e0fc into r0.4.0 Apr 8, 2026
86 checks passed
@ko3n1g
ko3n1g deleted the bump-ci-container-2026-04-07-r0.4.0-core_r0.17.0 branch April 8, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants