Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-04-05)#3160

Closed
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-04-05-main-dev
Closed

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-04-05)#3160
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-04-05-main-dev

Conversation

@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 5, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal development tracking and dependencies to align with latest versions.

Note: This release contains infrastructure and dependency updates with no user-facing changes or new features.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor Author

/ok to test dcc78a7

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

📝 Walkthrough

Walkthrough

This pull request updates the Megatron-LM submodule reference from commit 17a67b9a97fb11a75933fd7f76ad76e1ac98a53d to 8d1fd3c26be533a466b62392c379af1c4f5e0f01, and synchronizes the corresponding commit tracking file to the same hash.

Changes

Cohort / File(s) Summary
Megatron-LM Submodule & Commit Tracking
.dev.commit, 3rdparty/Megatron-LM
Updated Megatron-LM submodule pinned commit hash and synchronized the development commit tracking file to match the new upstream version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping uv.lock, but the actual changes update .dev.commit and the Megatron-LM submodule commit hash, not the uv.lock file. Update the title to accurately reflect the actual changes, such as 'chore: Update .dev.commit and Megatron-LM submodule (2026-04-05)' or clarify if uv.lock changes are expected but missing.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed Minor maintenance changes (submodule pointer update and metadata file change) without code logic modifications affecting numerics, convergence, or performance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-05-main-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The PR title wrongly references a `uv.lock` bump while the actual
change updates the Megatron-LM submodule pointer from commit
17a67b9a97fb11a75933fd7f76ad76e1ac98a53d to
8d1fd3c26be533a466b62392c379af1c4f5e0f01; update the PR title and description to
accurately state that this is a Megatron-LM submodule update (e.g., "Update
Megatron-LM submodule to 8d1fd3c") and include the commit range or summary of
changes between 17a67b9a... and 8d1fd3c... in the PR description.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 846e491a-b4e7-43ea-916f-ae3168c2e127

📥 Commits

Reviewing files that changed from the base of the PR and between ebca893 and dcc78a7.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .dev.commit
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 17a67b9a97fb11a75933fd7f76ad76e1ac98a53d
Subproject commit 8d1fd3c26be533a466b62392c379af1c4f5e0f01
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the Megatron-LM submodule update and check for notable changes

# Check if the submodule directory exists and inspect the commit range
cd 3rdparty/Megatron-LM 2>/dev/null || {
  echo "Submodule directory not found in sandbox"
  exit 0
}

OLD_COMMIT="17a67b9a97fb11a75933fd7f76ad76e1ac98a53d"
NEW_COMMIT="8d1fd3c26be533a466b62392c379af1c4f5e0f01"

echo "=== Verifying new commit exists ==="
git cat-file -t "$NEW_COMMIT" 2>/dev/null || echo "New commit not found in local clone"

echo -e "\n=== Commit range summary ==="
git log --oneline "${OLD_COMMIT}..${NEW_COMMIT}" 2>/dev/null || echo "Unable to generate commit range"

echo -e "\n=== Checking for breaking changes or API modifications ==="
git log --grep="breaking\|BREAKING\|deprecat" --oneline "${OLD_COMMIT}..${NEW_COMMIT}" 2>/dev/null || echo "No obvious breaking change markers found"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 305


Clarify PR title—it mentions uv.lock but changes a submodule pointer.

The PR title indicates a uv.lock bump, but the change updates the Megatron-LM submodule pointer from 17a67b9a97fb11a75933fd7f76ad76e1ac98a53d to 8d1fd3c26be533a466b62392c379af1c4f5e0f01. Update the PR title or description to accurately reflect that this is a submodule update.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The PR title wrongly references a `uv.lock`
bump while the actual change updates the Megatron-LM submodule pointer from
commit 17a67b9a97fb11a75933fd7f76ad76e1ac98a53d to
8d1fd3c26be533a466b62392c379af1c4f5e0f01; update the PR title and description to
accurately state that this is a Megatron-LM submodule update (e.g., "Update
Megatron-LM submodule to 8d1fd3c") and include the commit range or summary of
changes between 17a67b9a... and 8d1fd3c... in the PR description.

@yaoyu-33
Copy link
Copy Markdown
Contributor

yaoyu-33 commented Apr 6, 2026

Superseded by today's bump PR

@yaoyu-33 yaoyu-33 closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants