ci: Override onnx version to ensure lowerbound#3092
Conversation
Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a conditional dependency override for onnx (≥1.21.0) in pyproject.toml that applies only when Python version is less than 3.13. This introduces version-specific package installation behavior via the uv package manager's override-dependencies configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do ?
Issue:
onnx 1.19.0 has a bug in its PyPI metadata -- it uses ml_dtypes.float4_e2m1fn (added in ml-dtypes 0.5.0) but declares ml-dtypes with no version constraint.
for Python >= 3.13 ml-dtypes>=0.5.0 requires numpy>=2.1.0, which conflicts with the build dependency group's numpy<2.0.0.
Solution:
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit