Skip to content

[ci] chore: mark nano autoconfig roundtrip as pleasefixme and remove redundant launch script - #3091

Merged
yaoyu-33 merged 1 commit into
mainfrom
chcui/pleasefixme-nano-autoconfig-roundtrip
Apr 1, 2026
Merged

[ci] chore: mark nano autoconfig roundtrip as pleasefixme and remove redundant launch script#3091
yaoyu-33 merged 1 commit into
mainfrom
chcui/pleasefixme-nano-autoconfig-roundtrip

Conversation

@cuichenx

@cuichenx cuichenx commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Marks TestNemotron3NanoConversion::test_nemotron_3_nano_autoconfig_roundtrip with @pytest.mark.pleasefixme since it is currently broken in the ci environment. THe test runs successfully in the local environment.
  • Removes L1_Launch_autoconfig_roundtrip.sh which is redundant — the autoconfig roundtrip tests are already collected by the per-model launch scripts.

Test plan

  • Verify CI no longer runs the removed launch script
  • Verify the marked test is skipped in CI runs

Summary by CodeRabbit

  • Tests
    • Removed an automated test execution script
    • Marked a conversion test to exclude from regular test runs pending fixes

…redundant launch script

The autoconfig_roundtrip tests are already collected by the per-model
launch scripts, so the standalone L1_Launch_autoconfig_roundtrip.sh is
redundant. Also mark test_nemotron_3_nano_autoconfig_roundtrip with
pleasefixme since it is currently broken.

Signed-off-by: Chen Cui <chcui@nvidia.com>
@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A launch script for autoconfig roundtrip tests was deleted, and a test method was marked with a pleasefixme marker to skip it from regular test execution.

Changes

Cohort / File(s) Summary
Deleted Test Launch Script
tests/functional_tests/launch_scripts/active/L1_Launch_autoconfig_roundtrip.sh
Removed shell script that executed pytest with coverage instrumentation targeting autoconfig roundtrip tests.
Test Marker Update
tests/functional_tests/test_groups/models/nemotronh/test_nemotron_h_conversion.py
Added @pytest.mark.pleasefixme decorator to TestNemotron3NanoConversion.test_nemotron_3_nano_autoconfig_roundtrip test method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes both main changes: marking a test with pleasefixme and removing a redundant launch script.
Test Results For Major Changes ✅ Passed PR contains only minor CI chore changes: removing a redundant launch script and marking a broken test, with clear test plan and no impact on numerics or performance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chcui/pleasefixme-nano-autoconfig-roundtrip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/functional_tests/test_groups/models/nemotronh/test_nemotron_h_conversion.py (1)

605-607: Add a comment explaining why this test is marked pleasefixme.

Other uses of @pytest.mark.pleasefixme in this file include explanatory comments (e.g., # PP=2 broken by hybrid_layer_pattern (PR #2628)). Adding a similar comment here would help future maintainers understand the root cause and when the test can be re-enabled.

📝 Suggested change
     `@pytest.mark.run_only_on`("GPU")
-    `@pytest.mark.pleasefixme`
+    `@pytest.mark.pleasefixme`  # TODO: <explain why broken and link to tracking issue>
     def test_nemotron_3_nano_autoconfig_roundtrip(self, nemotron_3_nano_toy_model_path, tmp_path):
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@tests/functional_tests/test_groups/models/nemotronh/test_nemotron_h_conversion.py`
around lines 605 - 607, Add an inline comment above the `@pytest.mark.pleasefixme`
on the test_nemotron_3_nano_autoconfig_roundtrip function explaining the
specific reason this test is marked as pleasefixme (e.g., which bug/PR/issue
causes it to fail, relevant failure symptoms, and any conditions like GPU-only),
and include a reference ID (issue number or PR) and guidance for when it can be
re-enabled so future maintainers understand the root cause and resolution path.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@tests/functional_tests/test_groups/models/nemotronh/test_nemotron_h_conversion.py`:
- Around line 605-607: Add an inline comment above the `@pytest.mark.pleasefixme`
on the test_nemotron_3_nano_autoconfig_roundtrip function explaining the
specific reason this test is marked as pleasefixme (e.g., which bug/PR/issue
causes it to fail, relevant failure symptoms, and any conditions like GPU-only),
and include a reference ID (issue number or PR) and guidance for when it can be
re-enabled so future maintainers understand the root cause and resolution path.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39d97732-1309-4ccc-8862-f05d3350edb8

📥 Commits

Reviewing files that changed from the base of the PR and between fe02040 and 0dec496.

📒 Files selected for processing (2)
  • tests/functional_tests/launch_scripts/active/L1_Launch_autoconfig_roundtrip.sh
  • tests/functional_tests/test_groups/models/nemotronh/test_nemotron_h_conversion.py
💤 Files with no reviewable changes (1)
  • tests/functional_tests/launch_scripts/active/L1_Launch_autoconfig_roundtrip.sh

@yaoyu-33
yaoyu-33 merged commit d461e5d into main Apr 1, 2026
14 of 15 checks passed
@yaoyu-33
yaoyu-33 deleted the chcui/pleasefixme-nano-autoconfig-roundtrip branch April 1, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants