[build] fix: pre-install grpcio-tools before nvidia-resiliency-ext 0.6.0 build#3085
[build] fix: pre-install grpcio-tools before nvidia-resiliency-ext 0.6.0 build#3085
Conversation
|
/ok to test 116df34 |
📝 WalkthroughWalkthroughThe pull request updates a commit reference across two files and extends the build configuration. A commit hash is updated in two locations, and Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.main.commit:
- Line 1: The PR mentions adding "nvidia-resiliency-ext" to [tool.uv]
no-build-isolation-package in pyproject.toml but the diff only updates the
commit hash in .main.commit; verify and either add the actual pyproject.toml
change or clarify the relation: update pyproject.toml to include
"nvidia-resiliency-ext" under [tool.uv] no-build-isolation-package (or confirm
the change exists on the commit referenced by .main.commit) and update the PR
description to state whether the .main.commit hash points to the commit that
contains that pyproject.toml modification (reference files: pyproject.toml and
.main.commit).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e016e7e9-9932-4c6a-ba10-df9ff0172b3e
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.main.commit3rdparty/Megatron-LMpyproject.toml
.main.commit
Outdated
| @@ -1 +1 @@ | |||
| 3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d | |||
| 97e36aaba37245e2fa23d4fda0e956ece21e6c9e | |||
There was a problem hiding this comment.
Inconsistency: PR description mentions pyproject.toml changes, but only commit hash update is provided for review.
The PR objectives state that the fix involves adding "nvidia-resiliency-ext" to [tool.uv] no-build-isolation-package in pyproject.toml to disable build isolation. However, only .main.commit (a commit hash reference) is provided for review.
Please verify:
- Are the
pyproject.tomlchanges included in this PR? - Is the commit hash update in
.main.commitrelated to the build isolation fix, or is it tracking an unrelated upstream dependency update?
Without reviewing the actual pyproject.toml modifications, I cannot confirm that the core fix described in the PR objectives has been implemented.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.main.commit at line 1, The PR mentions adding "nvidia-resiliency-ext" to
[tool.uv] no-build-isolation-package in pyproject.toml but the diff only updates
the commit hash in .main.commit; verify and either add the actual pyproject.toml
change or clarify the relation: update pyproject.toml to include
"nvidia-resiliency-ext" under [tool.uv] no-build-isolation-package (or confirm
the change exists on the commit referenced by .main.commit) and update the PR
description to state whether the .main.commit hash points to the commit that
contains that pyproject.toml modification (reference files: pyproject.toml and
.main.commit).
|
/ok to test c5e847c |
9a157b9 to
d2d7013
Compare
nvidia-resiliency-ext 0.6.0 compiles proto files at build time via grpc_tools.protoc, but grpcio-tools is only a runtime dep and is not pre-installed by the --no-build-isolation setup. Adding it via the new extra-no-build-isolation-packages template input ensures it is available before the build runs. Bumps FW-CI-templates to 5e47529 (NVIDIA-NeMo/FW-CI-templates#440). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
d2d7013 to
1ca65f0
Compare
Signed-off-by: oliver könig <okoenig@nvidia.com>
…6.0 build (#3085) Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Summary
The automated
uv.lockbump in #3081 upgradednvidia-resiliency-extfromv0.5.0to0.6.0. The new version compiles proto files at build time via `grpc_tools.protoc`, but `grpcio-tools` is only declared as a runtime dependency — not in `build-system.requires`. The CI pre-install step doesn't know to install it first, causing:```
ModuleNotFoundError: No module named 'grpc_tools'
```
Fix: pass `grpcio-tools` via the new `extra-no-build-isolation-packages` input added in NVIDIA-NeMo/FW-CI-templates#440. This pre-installs it before `uv pip install --no-build-isolation -e .` runs, so the build script can find `grpc_tools.protoc`.
Test plan
build-test-publish-wheel / build-wheelpasses🤖 Generated with Claude Code